You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2017/10/17 10:21:40 UTC
kafka git commit: KAFKA-4504;
Clarify that retention.bytes is a partition level config
Repository: kafka
Updated Branches:
refs/heads/trunk 6c416acee -> 9c346ddc7
KAFKA-4504; Clarify that retention.bytes is a partition level config
Author: Manikumar Reddy <ma...@gmail.com>
Reviewers: Guozhang Wang <wa...@gmail.com>, Ismael Juma <is...@juma.me.uk>
Closes #3814 from omkreddy/KAFKA-4504
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/9c346ddc
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/9c346ddc
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/9c346ddc
Branch: refs/heads/trunk
Commit: 9c346ddc724d04a1e3d87baf6785c03a5909b161
Parents: 6c416ac
Author: Manikumar Reddy <ma...@gmail.com>
Authored: Tue Oct 17 11:21:34 2017 +0100
Committer: Ismael Juma <is...@juma.me.uk>
Committed: Tue Oct 17 11:21:34 2017 +0100
----------------------------------------------------------------------
.../java/org/apache/kafka/common/config/TopicConfig.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/9c346ddc/clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java b/clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java
index 2cbfad0..168dd25 100755
--- a/clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java
+++ b/clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java
@@ -63,9 +63,11 @@ public class TopicConfig {
"flush capabilities as it is more efficient.";
public static final String RETENTION_BYTES_CONFIG = "retention.bytes";
- public static final String RETENTION_BYTES_DOC = "This configuration controls the maximum size a log can grow " +
- "to before we will discard old log segments to free up space if we are using the " +
- "\"delete\" retention policy. By default there is no size limit only a time limit.";
+ public static final String RETENTION_BYTES_DOC = "This configuration controls the maximum size a partition " +
+ "(which consists of log segments) can grow to before we will discard old log segments to free up space if we " +
+ "are using the \"delete\" retention policy. By default there is no size limit only a time limit. " +
+ "Since this limit is enforced at the partition level, multiply it by the number of partitions to compute " +
+ "the topic retention in bytes.";
public static final String RETENTION_MS_CONFIG = "retention.ms";
public static final String RETENTION_MS_DOC = "This configuration controls the maximum time we will retain a " +