[jira] Commented: (ROL-1803) Comments.jsp

["Dave Johnson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROL-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712488#action_12712488 ] 

Dave Johnson commented on ROL-1803:
-----------------------------------

Great bug report, as usual Greg.

I fixed the issue with the missing parenthesis on length()
   http://svn.apache.org/viewvc?rev=778077&view=rev

But, I don't understand what you are trying to fix with "return DateUtil.getEndOfDay(newDate);" -- don't we want to use the actual start and finish dates and not use current time for end date?

Thanks,
- Dave


> Comments.jsp 
> -------------
>
>                 Key: ROL-1803
>                 URL: https://issues.apache.org/jira/browse/ROL-1803
>             Project: Roller
>          Issue Type: Bug
>    Affects Versions: 5.0
>            Reporter: Greg Huber
>            Assignee: Roller Unassigned
>            Priority: Trivial
>
> hello,
> In comments.jsp there is a line #334 <s:if test="#comment.content.length > 1000"> this needs to be 
> <s:if test="#comment.content.length() > 1000"> for it to work, ie .length().  The servlet will never get used!
> Also, possibly in CommentsBean/GlobalCommentsBean, to make more sense for the query:
>     public Date getEndDate() {
>         if(!StringUtils.isEmpty(getEndDateString())) 
>         try {
>             DateFormat df = new SimpleDateFormat("MM/dd/yy");
>             return df.parse(getEndDateString());
>         } catch(Exception e) { }
>         return null;
>     }
> needs to be:
>    public Date getEndDate() {
>         if(!StringUtils.isEmpty(getEndDateString())) 
>         try {
>             DateFormat df = new SimpleDateFormat("MM/dd/yy");
>             //return df.parse(getEndDateString());
>             return DateUtil.getEndOfDay(newDate); <<<<<<<<<<<<<<<<<
>         } catch(Exception e) { }
>         return null;
>     }
> Cheers Greg

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.