You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/26 09:46:46 UTC

[GitHub] tillrohrmann commented on a change in pull request #6763: [FLINK-10415] Fail response future if connection closes in RestClient

tillrohrmann commented on a change in pull request #6763: [FLINK-10415] Fail response future if connection closes in RestClient
URL: https://github.com/apache/flink/pull/6763#discussion_r220495572
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java
 ##########
 @@ -428,6 +447,12 @@ protected void channelRead0(ChannelHandlerContext ctx, Object msg) {
 			ctx.close();
 		}
 
+		@Override
+		public void channelInactive(ChannelHandlerContext ctx) throws Exception {
 
 Review comment:
   True, will fix it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services