You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/01/20 13:10:47 UTC
[GitHub] [buildstream] gtristan opened a new pull request #1445: Revive the remote cache service testing
gtristan opened a new pull request #1445:
URL: https://github.com/apache/buildstream/pull/1445
This revives the tests which run under `tox -- --remote-cache`, one of which runs against `bst-artifact-server` and another which runs against the corresponding buildbarn services.
This also refactors the tests a bit to improve on code reuse, and adds a new `service-tests` matrix to run the tests which require running an additional service in the background while the `bst` frontend tests run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a change in pull request #1445: Revive the remote cache service testing
Posted by GitBox <gi...@apache.org>.
gtristan commented on a change in pull request #1445:
URL: https://github.com/apache/buildstream/pull/1445#discussion_r560999822
##########
File path: .github/compose/ci.docker-compose.yml
##########
@@ -58,6 +58,45 @@ services:
environment:
BST_PLUGINS_EXPERIMENTAL_VERSION: master
+ remote-execution:
+ <<: *tests-template
+ command: tox -vvvvv -- --color=yes --remote-execution
+ environment:
+ TOXENV: ${CI_TOXENV_MAIN}
+ ARTIFACT_CACHE_SERVICE: http://localhost:50052
+ REMOTE_EXECUTION_SERVICE: http://localhost:50051
+ SOURCE_CACHE_SERVICE: http://localhost:50052
+
+ # We need to use host networking mode in order to be able to
+ # properly resolve services exposed by adjacent containers.
+ #
+ network_mode: host
+
+ buildstream-remote-cache:
+ <<: *tests-template
+ command: tox -vvvvv -- --color=yes --remote-cache
+ environment:
+ TOXENV: ${CI_TOXENV_MAIN}
+ ARTIFACT_CACHE_SERVICE: http://localhost:50052
+
+ # We need to use host networking mode in order to be able to
+ # properly resolve services exposed by adjacent containers.
+ #
+ network_mode: host
Review comment:
Yeah I struggled with this, won't be fixing this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a change in pull request #1445: Revive the remote cache service testing
Posted by GitBox <gi...@apache.org>.
gtristan commented on a change in pull request #1445:
URL: https://github.com/apache/buildstream/pull/1445#discussion_r560999394
##########
File path: .github/compose/ci.buildbarn-remote-cache.yml
##########
@@ -0,0 +1,59 @@
+##
+# Buildbarn Compose manifest for BuildStream.
+#
+# Spins-up a unnamed and unauthenticated cache server:
+# - STORAGE at http://localhost:7982
+# - INDEX at: http://localhost:7981
+#
+# BuildStream configuration snippet:
+#
+# artifacts:
+# - url: https://localhost:7981
+# type: index
+# push: true
+# - url: https://localhost:7982
+# type: storage
+# push: true
+#
+# Basic usage:
+# - docker-compose -f ci.buildbarn-remote-cache.yml up
+# - docker-compose -f ci.buildbarn-remote-cache.yml down
+
+version: '3.4'
+
+services:
+ bb-asset:
+ image: buildbarn/bb-remote-asset:20200903T103837Z-90136c4
+ command: /config/asset.jsonnet
+ restart: unless-stopped
+ expose:
Review comment:
Removed this now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1445: Revive the remote cache service testing
Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1445:
URL: https://github.com/apache/buildstream/pull/1445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a change in pull request #1445: Revive the remote cache service testing
Posted by GitBox <gi...@apache.org>.
gtristan commented on a change in pull request #1445:
URL: https://github.com/apache/buildstream/pull/1445#discussion_r560998966
##########
File path: .github/compose/ci.docker-compose.yml
##########
@@ -58,6 +58,45 @@ services:
environment:
BST_PLUGINS_EXPERIMENTAL_VERSION: master
+ remote-execution:
+ <<: *tests-template
+ command: tox -vvvvv -- --color=yes --remote-execution
+ environment:
+ TOXENV: ${CI_TOXENV_MAIN}
+ ARTIFACT_CACHE_SERVICE: http://localhost:50052
+ REMOTE_EXECUTION_SERVICE: http://localhost:50051
+ SOURCE_CACHE_SERVICE: http://localhost:50052
+
+ # We need to use host networking mode in order to be able to
+ # properly resolve services exposed by adjacent containers.
+ #
+ network_mode: host
+
+ buildstream-remote-cache:
+ <<: *tests-template
+ command: tox -vvvvv -- --color=yes --remote-cache
+ environment:
+ TOXENV: ${CI_TOXENV_MAIN}
+ ARTIFACT_CACHE_SERVICE: http://localhost:50052
+
+ # We need to use host networking mode in order to be able to
+ # properly resolve services exposed by adjacent containers.
+ #
+ network_mode: host
Review comment:
removed this now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] cs-shadow commented on a change in pull request #1445: Revive the remote cache service testing
Posted by GitBox <gi...@apache.org>.
cs-shadow commented on a change in pull request #1445:
URL: https://github.com/apache/buildstream/pull/1445#discussion_r560962277
##########
File path: .github/compose/ci.docker-compose.yml
##########
@@ -58,6 +58,45 @@ services:
environment:
BST_PLUGINS_EXPERIMENTAL_VERSION: master
+ remote-execution:
+ <<: *tests-template
+ command: tox -vvvvv -- --color=yes --remote-execution
+ environment:
+ TOXENV: ${CI_TOXENV_MAIN}
+ ARTIFACT_CACHE_SERVICE: http://localhost:50052
+ REMOTE_EXECUTION_SERVICE: http://localhost:50051
+ SOURCE_CACHE_SERVICE: http://localhost:50052
+
+ # We need to use host networking mode in order to be able to
+ # properly resolve services exposed by adjacent containers.
+ #
+ network_mode: host
+
+ buildstream-remote-cache:
+ <<: *tests-template
+ command: tox -vvvvv -- --color=yes --remote-cache
+ environment:
+ TOXENV: ${CI_TOXENV_MAIN}
+ ARTIFACT_CACHE_SERVICE: http://localhost:50052
+
+ # We need to use host networking mode in order to be able to
+ # properly resolve services exposed by adjacent containers.
+ #
+ network_mode: host
Review comment:
We don't have to resolve it at this time, but it'll be nice to not have to use host networking mode. Perhaps by sharing a docker network between this compose file and the ones for other services. Not blocking for now.
##########
File path: .github/compose/ci.buildbarn-remote-cache.yml
##########
@@ -0,0 +1,59 @@
+##
+# Buildbarn Compose manifest for BuildStream.
+#
+# Spins-up a unnamed and unauthenticated cache server:
+# - STORAGE at http://localhost:7982
+# - INDEX at: http://localhost:7981
+#
+# BuildStream configuration snippet:
+#
+# artifacts:
+# - url: https://localhost:7981
+# type: index
+# push: true
+# - url: https://localhost:7982
+# type: storage
+# push: true
+#
+# Basic usage:
+# - docker-compose -f ci.buildbarn-remote-cache.yml up
+# - docker-compose -f ci.buildbarn-remote-cache.yml down
+
+version: '3.4'
+
+services:
+ bb-asset:
+ image: buildbarn/bb-remote-asset:20200903T103837Z-90136c4
+ command: /config/asset.jsonnet
+ restart: unless-stopped
+ expose:
Review comment:
i think all these `expose` fields are redundant given that we expose them using `ports` anyway on the line below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org