You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/08/11 05:38:38 UTC
[GitHub] [airflow] uranusjr opened a new pull request, #33307: Add helpers to better handle session in tests
uranusjr opened a new pull request, #33307:
URL: https://github.com/apache/airflow/pull/33307
In various places we intentionally create dangling sessions in the worker, but when running a task in tests (which don't use workers) we need to make those not dangling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add helpers to better handle session in tests [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr closed pull request #33307: Add helpers to better handle session in tests
URL: https://github.com/apache/airflow/pull/33307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #33307: Add helpers to better handle session in tests
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #33307: Add helpers to better handle session in tests
URL: https://github.com/apache/airflow/pull/33307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #33307: Add helpers to better handle session in tests
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #33307:
URL: https://github.com/apache/airflow/pull/33307#issuecomment-1735052093
@potiuk I forgot the context on this, is this still needed after we have the cleanup context manager thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add helpers to better handle session in tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33307:
URL: https://github.com/apache/airflow/pull/33307#issuecomment-1752129404
No. No need. We are now (for a long time) closing all Sqlalchemy sessions between tests, so this is not needed even without context manager I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #33307: Add helpers to better handle session in tests
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33307:
URL: https://github.com/apache/airflow/pull/33307#issuecomment-1734632773
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org