You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/12 12:27:46 UTC
[GitHub] codecov-io commented on issue #5380: Add time grain blacklist and
tests for validity
codecov-io commented on issue #5380: Add time grain blacklist and tests for validity
URL: https://github.com/apache/incubator-superset/pull/5380#issuecomment-404494980
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5380?src=pr&el=h1) Report
> Merging [#5380](https://codecov.io/gh/apache/incubator-superset/pull/5380?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/cd2414b19e70b14de5f3b3b36e18904b06a25515?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5380/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/5380?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5380 +/- ##
==========================================
+ Coverage 61.31% 61.33% +0.01%
==========================================
Files 369 369
Lines 23497 23509 +12
Branches 2715 2715
==========================================
+ Hits 14407 14419 +12
Misses 9078 9078
Partials 12 12
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5380?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `54.61% <100%> (+0.78%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.29% <100%> (ø)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/5380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.64% <100%> (+0.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5380?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5380?src=pr&el=footer). Last update [cd2414b...efefddc](https://codecov.io/gh/apache/incubator-superset/pull/5380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org