[GitHub] [cloudstack] ravening commented on pull request #4215: Enable account settings to be visible under domain settings

[GitBox <gi...@apache.org>]

ravening commented on pull request #4215:
URL: https://github.com/apache/cloudstack/pull/4215#issuecomment-665547798


   > This quite a functional change @ravening .
   > Did you test settings for domains linked to ldap?
   > I read in your description that you are (kind of) mixing account level settings with domain level settings. some settings do not apply to domains and others do not apply to accounts.
   > 
   > I like your idea that the setting system should be hierarchical and agree, but it just isn't designed this way. the same issue exists in zone-pod-cluster-host.
   
   @DaanHoogland 
   
   I am enabling only account settings for domain and not the other way around. Also there are two global settings to control this.
   
   1. To enable all the account settings visible under domain
   2. To fetch values from domain if account setting value is not set
   
   The code is not making domain settings visible under account
   
   If the (1)st global setting is true then you can configure value under a domain and all accounts will see that value. If its disabled then account will get value from global setting.
   
   I didnt test it for ldap linked domains 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org