You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by matrosov-nikita <gi...@git.apache.org> on 2017/01/26 08:08:40 UTC
[GitHub] cordova-windows pull request #223: Remove duplicate logic after upgrading co...
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-windows/pull/223
Remove duplicate logic after upgrading cordova-common
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-windows remove-duplicate-logic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #223
----
commit 16167f585aac07333c9dafb1980409b6897b420d
Author: Nikita Matrosov <v-...@microsoft.com>
Date: 2017-01-26T08:05:19Z
Remove duplicate logic after upgrading cordova-common
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #223: Remove duplicate logic after upgrading cordova-c...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/223
## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/223?src=pr) is 76.85% (diff: 100%)
> Merging [#223](https://codecov.io/gh/apache/cordova-windows/pull/223?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will decrease coverage by **0.11%**
```diff
@@ master #223 diff @@
==========================================
Files 16 16
Lines 2232 2221 -11
Methods 415 412 -3
Messages 0 0
Branches 442 439 -3
==========================================
- Hits 1718 1707 -11
Misses 514 514
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [a0c0eda...16167f5](https://codecov.io/gh/apache/cordova-windows/compare/a0c0edacdad59e3c1099d6196fe7484c92f3fe57...16167f585aac07333c9dafb1980409b6897b420d?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #223: Remove duplicate logic after upgrading cordova-c...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/223
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request #223: Remove duplicate logic after upgrading co...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org