You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/17 04:33:44 UTC

[GitHub] [spark] zhengruifeng opened a new pull request #27600: [MINOR][ML] ML cleanup

zhengruifeng opened a new pull request #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600
 
 
   ### What changes were proposed in this pull request?
   1, remove used imports and variables;
   2, use `.iterator` instead of `.view` to avoid IDEA warnings;
   3, remove resolved _TODO_
   
   ### Why are the changes needed?
   cleanup
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   existing testsuites

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586900389
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586868825
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on a change in pull request #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#discussion_r381063088
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
 ##########
 @@ -1049,7 +1049,7 @@ object ALS extends DefaultParamsReadable[ALS] with Logging {
       .join(userFactors)
       .mapPartitions({ items =>
         items.flatMap { case (_, (ids, factors)) =>
-          ids.view.zip(factors)
+          ids.iterator.zip(factors.iterator)
 
 Review comment:
   I guess `.view` was used to avoid creating a new Array

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586868835
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23307/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on a change in pull request #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#discussion_r379982364
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/feature/MinMaxScaler.scala
 ##########
 @@ -144,8 +144,6 @@ object MinMaxScaler extends DefaultParamsReadable[MinMaxScaler] {
  *
  * @param originalMin min value for each original column during fitting
  * @param originalMax max value for each original column during fitting
- *
- * TODO: The transformer does not yet set the metadata in the output column (SPARK-8529).
 
 Review comment:
   metatdat was already attached in SPARK-29914

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586830044
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on a change in pull request #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#discussion_r380225303
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
 ##########
 @@ -256,7 +256,7 @@ class RandomForestClassificationModel private[ml] (
     // Classifies using majority votes.
     // Ignore the tree weights since all are 1.0 for now.
     val votes = Array.ofDim[Double](numClasses)
-    _trees.view.foreach { tree =>
+    _trees.foreach { tree =>
 
 Review comment:
   In some cases I think we used view to avoid copying the result of a map or something, but I don't think that's the case here. It's an Array.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586857734
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118535/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on a change in pull request #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#discussion_r380226459
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/mllib/clustering/StreamingKMeans.scala
 ##########
 @@ -95,7 +95,7 @@ class StreamingKMeansModel @Since("1.2.0") (
     val discount = timeUnit match {
       case StreamingKMeans.BATCHES => decayFactor
       case StreamingKMeans.POINTS =>
-        val numNewPoints = pointStats.view.map { case (_, (_, n)) =>
+        val numNewPoints = pointStats.iterator.map { case (_, (_, n)) =>
 
 Review comment:
   I guess same question - is the .view needed at all? I'm trying to think of what the original purpose was.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586833775
 
 
   **[Test build #118535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118535/testReport)** for PR 27600 at commit [`54d6fc3`](https://github.com/apache/spark/commit/54d6fc34af7e5f43465c3a2ed77a136dead3c824).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586834066
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586857725
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586829753
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118533/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586868485
 
 
   **[Test build #118553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118553/testReport)** for PR 27600 at commit [`c22b05b`](https://github.com/apache/spark/commit/c22b05b06cd85513f2516c2173fd8a32decf2ca0).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586816483
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118528/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586830044
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586830051
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23289/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586828097
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23288/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586828093
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586829753
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118533/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586868835
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23307/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-588020643
 
 
   This should be a bug in scala-plugin of IDEA, it can not correctly infer the types if `.view` is used.
   
   ![image](https://user-images.githubusercontent.com/7322292/74799971-0910d600-530d-11ea-8fb0-5498b3012eab.png)
   
   After change `.view` to `.iterator`:
   ![image](https://user-images.githubusercontent.com/7322292/74800023-2b0a5880-530d-11ea-8dfc-1e3d6a5c23aa.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586900389
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-591207484
 
 
   Thanks @srowen for reviewing!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586829746
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-588525832
 
 
   I see the same weird behavior with .view, but, just want to make sure we don't hurt some performance somewhere just to avoid it. I think you are generally right that .iterator works as well, and .view goes away or is deprecated in 2.13 (I forget), so I support it. In one or two cases I think .iterator isn't needed either, will comment above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586827771
 
 
   **[Test build #118533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118533/testReport)** for PR 27600 at commit [`b323a67`](https://github.com/apache/spark/commit/b323a67bbd343af68b16bbef68d9cbe207c6f222).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586834069
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23290/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586813414
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586829697
 
 
   **[Test build #118534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118534/testReport)** for PR 27600 at commit [`b261e23`](https://github.com/apache/spark/commit/b261e23c9abbfd4d3603d998cfeeb2ad8241a212).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586833775
 
 
   **[Test build #118535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118535/testReport)** for PR 27600 at commit [`54d6fc3`](https://github.com/apache/spark/commit/54d6fc34af7e5f43465c3a2ed77a136dead3c824).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586828097
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23288/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586814619
 
 
   **[Test build #118528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118528/testReport)** for PR 27600 at commit [`97a2680`](https://github.com/apache/spark/commit/97a2680ec65e586a1feb42124c2372f044555ad5).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586900399
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118553/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586828093
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586848335
 
 
   **[Test build #118534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118534/testReport)** for PR 27600 at commit [`b261e23`](https://github.com/apache/spark/commit/b261e23c9abbfd4d3603d998cfeeb2ad8241a212).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586816479
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-590154116
 
 
   @srowen I think converting `.view` to `.iterator` in ALS will not hur performance, since they are used in `mapPartitions` which need a `Iterator` as output, in current impl, I think the `IndexedSeqView` will be convertt to `Iterator` implicitly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586814619
 
 
   **[Test build #118528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118528/testReport)** for PR 27600 at commit [`97a2680`](https://github.com/apache/spark/commit/97a2680ec65e586a1feb42124c2372f044555ad5).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586868485
 
 
   **[Test build #118553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118553/testReport)** for PR 27600 at commit [`c22b05b`](https://github.com/apache/spark/commit/c22b05b06cd85513f2516c2173fd8a32decf2ca0).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586829746
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586829697
 
 
   **[Test build #118534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118534/testReport)** for PR 27600 at commit [`b261e23`](https://github.com/apache/spark/commit/b261e23c9abbfd4d3603d998cfeeb2ad8241a212).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586848923
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118534/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586848917
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586857734
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118535/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586900399
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118553/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586816467
 
 
   **[Test build #118528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118528/testReport)** for PR 27600 at commit [`97a2680`](https://github.com/apache/spark/commit/97a2680ec65e586a1feb42124c2372f044555ad5).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586830051
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23289/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on a change in pull request #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#discussion_r380225926
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
 ##########
 @@ -1049,7 +1049,7 @@ object ALS extends DefaultParamsReadable[ALS] with Logging {
       .join(userFactors)
       .mapPartitions({ items =>
         items.flatMap { case (_, (ids, factors)) =>
-          ids.view.zip(factors)
+          ids.iterator.zip(factors.iterator)
 
 Review comment:
   What's the warning BTW?  and does `ids.zip(factors)` not work here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586813419
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23281/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586813414
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586834069
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23290/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586899928
 
 
   **[Test build #118553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118553/testReport)** for PR 27600 at commit [`c22b05b`](https://github.com/apache/spark/commit/c22b05b06cd85513f2516c2173fd8a32decf2ca0).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-591000296
 
 
   Merged to master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586857344
 
 
   **[Test build #118535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118535/testReport)** for PR 27600 at commit [`54d6fc3`](https://github.com/apache/spark/commit/54d6fc34af7e5f43465c3a2ed77a136dead3c824).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586857725
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586848923
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118534/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on a change in pull request #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#discussion_r381603214
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
 ##########
 @@ -1049,7 +1049,7 @@ object ALS extends DefaultParamsReadable[ALS] with Logging {
       .join(userFactors)
       .mapPartitions({ items =>
         items.flatMap { case (_, (ids, factors)) =>
-          ids.view.zip(factors)
+          ids.iterator.zip(factors.iterator)
 
 Review comment:
   Hm, but it results in a new array already, so just removing .view seems to not change much here. Just in case @mengxr do you recall why? this was written 4 years ago, so may have been lost in time.
   
   The result would now be an iterator, which seems OK; avoids allocating an array after the change, I believe.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586813419
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23281/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586868825
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586834066
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586848917
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586816479
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586829723
 
 
   **[Test build #118533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118533/testReport)** for PR 27600 at commit [`b323a67`](https://github.com/apache/spark/commit/b323a67bbd343af68b16bbef68d9cbe207c6f222).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586827771
 
 
   **[Test build #118533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118533/testReport)** for PR 27600 at commit [`b323a67`](https://github.com/apache/spark/commit/b323a67bbd343af68b16bbef68d9cbe207c6f222).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-586816483
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118528/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen edited a comment on issue #27600: [MINOR][ML] ML cleanup

Posted by GitBox <gi...@apache.org>.
srowen edited a comment on issue #27600: [MINOR][ML] ML cleanup
URL: https://github.com/apache/spark/pull/27600#issuecomment-588525832
 
 
   I see the same weird behavior with .view, but, just want to make sure we don't hurt some performance somewhere just to avoid it. I think you are generally right that .iterator works as well, and .view goes away or is deprecated in 2.13 (I forget), so I support it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org