You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Feinauer <j....@pragmaticminds.de> on 2019/09/05 06:28:12 UTC
[DISCUSS] Release apache-calcite-1.21.0 (release candidate 0)
Hi,
I took the freedom to fork a DISCUSS thread to keep the VOTE thread a bit cleaner.
AFAIR these "pom.xml.next" come from the maven release plugin and show how the pom would look like in the next iteration (from "prepare" Phase)
Probably they were not cleaned up properly during "perform" phase.
Julian
Am 05.09.19, 08:04 schrieb "Danny Chan" <yu...@gmail.com>:
I made the diff cmd and also see these outputs, it seems that pom.xml.next and pom.xml.tag comes from a plugin ?
Best,
Danny Chan
在 2019年9月5日 +0800 AM2:53，Julian Hyde <jh...@apache.org>，写道：
> I’m still reviewing the release, but I have an observation and a question. There are a bunch of pom.xml.next and pom.xml.tag files that I’ve not seen before. What is the purpose of these?
>
> It’s OK that we include DEPENDENCIES (which is generated). I’m a bit surprised that we do not include .gitignore in the release.
>
> Julian
>
>
> $ cd /tmp
> $ tar xvfz ~/apache/dist/dev/calcite/apache-calcite-1.21.0-rc0/apache-calcite-1.21.0-src.tar.gz
> $ cd ~/dev/calcite
> $ git checkout calcite-1.21.0
> $ diff -r . /tmp/apache-calcite-1.21.0-src/
> Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/: DEPENDENCIES
> Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.tag
> Only in .: .git
> Only in .: .gitattributes
> Only in .: .gitignore
> Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.tag
>
>
> > On Sep 4, 2019, at 8:23 AM, Anton Haidai <an...@gmail.com> wrote:
> >
> > Hello,
> >
> > Let me join the vote as far as my Calcite-base project
> > https://www.zoomdata.com/ has an extensive test suite that was able to
> > detect two major issues (CALCITE-3145, CALCITE-3162) in the previous 1.20
> > release (unfortunately, after the Calcite release itself during a
> > migration).
> >
> >
> > So here are Calcite 1.21.0 testing results:
> >
> > Local Calcite build with tests enabled on Linux: OK
> >
> > Calcite-based system test suite: OK
> >
> >
> > +1 (non-binding)
> >
> > On Wed, Sep 4, 2019 at 2:55 AM Julian Hyde <jh...@apache.org> wrote:
> >
> > > Regarding the 'ps' failures. I've added a suggestion to
> > >
> > > https://issues.apache.org/jira/browse/CALCITE-2816?focusedCommentId=16921772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16921772
> > > .
> > > Let's continue conversation there. Release threads are not a place for
> > > technical discussion.
> > >
> > > On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer
> > > <j....@pragmaticminds.de> wrote:
> > > >
> > > > Thanks Vladimir,
> > > >
> > > > This would also be my first assumption that its due to German locale
> > > which also causes problems with parsing frequently.
> > > >
> > > > I think we should either fix that or note it somewhere in the how to to
> > > ensure that people can reproduce the build, so I think I should keep my -1
> > > (but it's not binding so not that big of an issue).
> > > >
> > > > Julian
> > > >
> > > > Von meinem Mobiltelefon gesendet
> > > >
> > > >
> > > > -------- Ursprüngliche Nachricht --------
> > > > Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
> > > > Von: Vladimir Sitnikov
> > > > An: Apache Calcite dev list
> > > > Cc:
> > > >
> > > > It is a "well known"
> > > > https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction
> > > > fails in Russian locale
> > > >
> > > > In other words, "float number parsing is locale-sensitive".
> > > > Vladimir
> > >
> >
> >
> > --
> > Best regards,
> > Anton.
>
Re: [DISCUSS] Release apache-calcite-1.21.0 (release candidate
0)
Posted by Danny Chan <yu...@gmail.com>.
I think we should not include these .xml.xxx files into the jar. Also the .gitignore file be included.
Best,
Danny Chan
在 2019年9月5日 +0800 PM3:23，Julian Feinauer <j....@pragmaticminds.de>，写道：
> Hey,
>
> I'm not sure if we need to cancel it ASAP, I would wait for the results of Julian (Hyde) and Danny and their binding votes.
> As every PMC handles that a bit differently I'm unsure whether you consider that "major enough" or not.
>
> Julian
>
> Am 05.09.19, 09:19 schrieb "Stamatis Zampetakis" <za...@gmail.com>:
>
> Sorry about that, I will cancel the vote and start a new one for rc1 ASAP.
>
> In the meantime, do we want to fix CALCITE-2816 (or skip the relevant tests
> for problematic locales)?
>
> On Thu, Sep 5, 2019 at 8:28 AM Julian Feinauer <j....@pragmaticminds.de>
> wrote:
>
> > Hi,
> >
> > I took the freedom to fork a DISCUSS thread to keep the VOTE thread a bit
> > cleaner.
> >
> > AFAIR these "pom.xml.next" come from the maven release plugin and show how
> > the pom would look like in the next iteration (from "prepare" Phase)
> > Probably they were not cleaned up properly during "perform" phase.
> >
> > Julian
> >
> > Am 05.09.19, 08:04 schrieb "Danny Chan" <yu...@gmail.com>:
> >
> > I made the diff cmd and also see these outputs, it seems that
> > pom.xml.next and pom.xml.tag comes from a plugin ?
> >
> > Best,
> > Danny Chan
> > 在 2019年9月5日 +0800 AM2:53，Julian Hyde <jh...@apache.org>，写道：
> > > I’m still reviewing the release, but I have an observation and a
> > question. There are a bunch of pom.xml.next and pom.xml.tag files that I’ve
> > not seen before. What is the purpose of these?
> > >
> > > It’s OK that we include DEPENDENCIES (which is generated). I’m a bit
> > surprised that we do not include .gitignore in the release.
> > >
> > > Julian
> > >
> > >
> > > $ cd /tmp
> > > $ tar xvfz
> > ~/apache/dist/dev/calcite/apache-calcite-1.21.0-rc0/apache-calcite-1.21.0-src.tar.gz
> > > $ cd ~/dev/calcite
> > > $ git checkout calcite-1.21.0
> > > $ diff -r . /tmp/apache-calcite-1.21.0-src/
> > > Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/: DEPENDENCIES
> > > Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.tag
> > > Only in .: .git
> > > Only in .: .gitattributes
> > > Only in .: .gitignore
> > > Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.tag
> > > Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.next
> > > Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.tag
> > >
> > >
> > > > On Sep 4, 2019, at 8:23 AM, Anton Haidai <an...@gmail.com>
> > wrote:
> > > >
> > > > Hello,
> > > >
> > > > Let me join the vote as far as my Calcite-base project
> > > > https://www.zoomdata.com/ has an extensive test suite that was
> > able to
> > > > detect two major issues (CALCITE-3145, CALCITE-3162) in the
> > previous 1.20
> > > > release (unfortunately, after the Calcite release itself during a
> > > > migration).
> > > >
> > > >
> > > > So here are Calcite 1.21.0 testing results:
> > > >
> > > > Local Calcite build with tests enabled on Linux: OK
> > > >
> > > > Calcite-based system test suite: OK
> > > >
> > > >
> > > > +1 (non-binding)
> > > >
> > > > On Wed, Sep 4, 2019 at 2:55 AM Julian Hyde <jh...@apache.org>
> > wrote:
> > > >
> > > > > Regarding the 'ps' failures. I've added a suggestion to
> > > > >
> > > > >
> > https://issues.apache.org/jira/browse/CALCITE-2816?focusedCommentId=16921772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16921772
> > > > > .
> > > > > Let's continue conversation there. Release threads are not a
> > place for
> > > > > technical discussion.
> > > > >
> > > > > On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer
> > > > > <j....@pragmaticminds.de> wrote:
> > > > > >
> > > > > > Thanks Vladimir,
> > > > > >
> > > > > > This would also be my first assumption that its due to German
> > locale
> > > > > which also causes problems with parsing frequently.
> > > > > >
> > > > > > I think we should either fix that or note it somewhere in the
> > how to to
> > > > > ensure that people can reproduce the build, so I think I should
> > keep my -1
> > > > > (but it's not binding so not that big of an issue).
> > > > > >
> > > > > > Julian
> > > > > >
> > > > > > Von meinem Mobiltelefon gesendet
> > > > > >
> > > > > >
> > > > > > -------- Ursprüngliche Nachricht --------
> > > > > > Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release
> > candidate 0)
> > > > > > Von: Vladimir Sitnikov
> > > > > > An: Apache Calcite dev list
> > > > > > Cc:
> > > > > >
> > > > > > It is a "well known"
> > > > > > https://issues.apache.org/jira/browse/CALCITE-2816
> > PsTableFunction
> > > > > > fails in Russian locale
> > > > > >
> > > > > > In other words, "float number parsing is locale-sensitive".
> > > > > > Vladimir
> > > > >
> > > >
> > > >
> > > > --
> > > > Best regards,
> > > > Anton.
> > >
> >
> >
> >
>
>
Re: [DISCUSS] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hey,
I'm not sure if we need to cancel it ASAP, I would wait for the results of Julian (Hyde) and Danny and their binding votes.
As every PMC handles that a bit differently I'm unsure whether you consider that "major enough" or not.
Julian
Am 05.09.19, 09:19 schrieb "Stamatis Zampetakis" <za...@gmail.com>:
Sorry about that, I will cancel the vote and start a new one for rc1 ASAP.
In the meantime, do we want to fix CALCITE-2816 (or skip the relevant tests
for problematic locales)?
On Thu, Sep 5, 2019 at 8:28 AM Julian Feinauer <j....@pragmaticminds.de>
wrote:
> Hi,
>
> I took the freedom to fork a DISCUSS thread to keep the VOTE thread a bit
> cleaner.
>
> AFAIR these "pom.xml.next" come from the maven release plugin and show how
> the pom would look like in the next iteration (from "prepare" Phase)
> Probably they were not cleaned up properly during "perform" phase.
>
> Julian
>
> Am 05.09.19, 08:04 schrieb "Danny Chan" <yu...@gmail.com>:
>
> I made the diff cmd and also see these outputs, it seems that
> pom.xml.next and pom.xml.tag comes from a plugin ?
>
> Best,
> Danny Chan
> 在 2019年9月5日 +0800 AM2:53，Julian Hyde <jh...@apache.org>，写道：
> > I’m still reviewing the release, but I have an observation and a
> question. There are a bunch of pom.xml.next and pom.xml.tag files that I’ve
> not seen before. What is the purpose of these?
> >
> > It’s OK that we include DEPENDENCIES (which is generated). I’m a bit
> surprised that we do not include .gitignore in the release.
> >
> > Julian
> >
> >
> > $ cd /tmp
> > $ tar xvfz
> ~/apache/dist/dev/calcite/apache-calcite-1.21.0-rc0/apache-calcite-1.21.0-src.tar.gz
> > $ cd ~/dev/calcite
> > $ git checkout calcite-1.21.0
> > $ diff -r . /tmp/apache-calcite-1.21.0-src/
> > Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/: DEPENDENCIES
> > Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.tag
> > Only in .: .git
> > Only in .: .gitattributes
> > Only in .: .gitignore
> > Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.tag
> >
> >
> > > On Sep 4, 2019, at 8:23 AM, Anton Haidai <an...@gmail.com>
> wrote:
> > >
> > > Hello,
> > >
> > > Let me join the vote as far as my Calcite-base project
> > > https://www.zoomdata.com/ has an extensive test suite that was
> able to
> > > detect two major issues (CALCITE-3145, CALCITE-3162) in the
> previous 1.20
> > > release (unfortunately, after the Calcite release itself during a
> > > migration).
> > >
> > >
> > > So here are Calcite 1.21.0 testing results:
> > >
> > > Local Calcite build with tests enabled on Linux: OK
> > >
> > > Calcite-based system test suite: OK
> > >
> > >
> > > +1 (non-binding)
> > >
> > > On Wed, Sep 4, 2019 at 2:55 AM Julian Hyde <jh...@apache.org>
> wrote:
> > >
> > > > Regarding the 'ps' failures. I've added a suggestion to
> > > >
> > > >
> https://issues.apache.org/jira/browse/CALCITE-2816?focusedCommentId=16921772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16921772
> > > > .
> > > > Let's continue conversation there. Release threads are not a
> place for
> > > > technical discussion.
> > > >
> > > > On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer
> > > > <j....@pragmaticminds.de> wrote:
> > > > >
> > > > > Thanks Vladimir,
> > > > >
> > > > > This would also be my first assumption that its due to German
> locale
> > > > which also causes problems with parsing frequently.
> > > > >
> > > > > I think we should either fix that or note it somewhere in the
> how to to
> > > > ensure that people can reproduce the build, so I think I should
> keep my -1
> > > > (but it's not binding so not that big of an issue).
> > > > >
> > > > > Julian
> > > > >
> > > > > Von meinem Mobiltelefon gesendet
> > > > >
> > > > >
> > > > > -------- Ursprüngliche Nachricht --------
> > > > > Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release
> candidate 0)
> > > > > Von: Vladimir Sitnikov
> > > > > An: Apache Calcite dev list
> > > > > Cc:
> > > > >
> > > > > It is a "well known"
> > > > > https://issues.apache.org/jira/browse/CALCITE-2816
> PsTableFunction
> > > > > fails in Russian locale
> > > > >
> > > > > In other words, "float number parsing is locale-sensitive".
> > > > > Vladimir
> > > >
> > >
> > >
> > > --
> > > Best regards,
> > > Anton.
> >
>
>
>
Re: [DISCUSS] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Stamatis Zampetakis <za...@gmail.com>.
Sorry about that, I will cancel the vote and start a new one for rc1 ASAP.
In the meantime, do we want to fix CALCITE-2816 (or skip the relevant tests
for problematic locales)?
On Thu, Sep 5, 2019 at 8:28 AM Julian Feinauer <j....@pragmaticminds.de>
wrote:
> Hi,
>
> I took the freedom to fork a DISCUSS thread to keep the VOTE thread a bit
> cleaner.
>
> AFAIR these "pom.xml.next" come from the maven release plugin and show how
> the pom would look like in the next iteration (from "prepare" Phase)
> Probably they were not cleaned up properly during "perform" phase.
>
> Julian
>
> Am 05.09.19, 08:04 schrieb "Danny Chan" <yu...@gmail.com>:
>
> I made the diff cmd and also see these outputs, it seems that
> pom.xml.next and pom.xml.tag comes from a plugin ?
>
> Best,
> Danny Chan
> 在 2019年9月5日 +0800 AM2:53，Julian Hyde <jh...@apache.org>，写道：
> > I’m still reviewing the release, but I have an observation and a
> question. There are a bunch of pom.xml.next and pom.xml.tag files that I’ve
> not seen before. What is the purpose of these?
> >
> > It’s OK that we include DEPENDENCIES (which is generated). I’m a bit
> surprised that we do not include .gitignore in the release.
> >
> > Julian
> >
> >
> > $ cd /tmp
> > $ tar xvfz
> ~/apache/dist/dev/calcite/apache-calcite-1.21.0-rc0/apache-calcite-1.21.0-src.tar.gz
> > $ cd ~/dev/calcite
> > $ git checkout calcite-1.21.0
> > $ diff -r . /tmp/apache-calcite-1.21.0-src/
> > Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/: DEPENDENCIES
> > Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.tag
> > Only in .: .git
> > Only in .: .gitattributes
> > Only in .: .gitignore
> > Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.tag
> >
> >
> > > On Sep 4, 2019, at 8:23 AM, Anton Haidai <an...@gmail.com>
> wrote:
> > >
> > > Hello,
> > >
> > > Let me join the vote as far as my Calcite-base project
> > > https://www.zoomdata.com/ has an extensive test suite that was
> able to
> > > detect two major issues (CALCITE-3145, CALCITE-3162) in the
> previous 1.20
> > > release (unfortunately, after the Calcite release itself during a
> > > migration).
> > >
> > >
> > > So here are Calcite 1.21.0 testing results:
> > >
> > > Local Calcite build with tests enabled on Linux: OK
> > >
> > > Calcite-based system test suite: OK
> > >
> > >
> > > +1 (non-binding)
> > >
> > > On Wed, Sep 4, 2019 at 2:55 AM Julian Hyde <jh...@apache.org>
> wrote:
> > >
> > > > Regarding the 'ps' failures. I've added a suggestion to
> > > >
> > > >
> https://issues.apache.org/jira/browse/CALCITE-2816?focusedCommentId=16921772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16921772
> > > > .
> > > > Let's continue conversation there. Release threads are not a
> place for
> > > > technical discussion.
> > > >
> > > > On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer
> > > > <j....@pragmaticminds.de> wrote:
> > > > >
> > > > > Thanks Vladimir,
> > > > >
> > > > > This would also be my first assumption that its due to German
> locale
> > > > which also causes problems with parsing frequently.
> > > > >
> > > > > I think we should either fix that or note it somewhere in the
> how to to
> > > > ensure that people can reproduce the build, so I think I should
> keep my -1
> > > > (but it's not binding so not that big of an issue).
> > > > >
> > > > > Julian
> > > > >
> > > > > Von meinem Mobiltelefon gesendet
> > > > >
> > > > >
> > > > > -------- Ursprüngliche Nachricht --------
> > > > > Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release
> candidate 0)
> > > > > Von: Vladimir Sitnikov
> > > > > An: Apache Calcite dev list
> > > > > Cc:
> > > > >
> > > > > It is a "well known"
> > > > > https://issues.apache.org/jira/browse/CALCITE-2816
> PsTableFunction
> > > > > fails in Russian locale
> > > > >
> > > > > In other words, "float number parsing is locale-sensitive".
> > > > > Vladimir
> > > >
> > >
> > >
> > > --
> > > Best regards,
> > > Anton.
> >
>
>
>