You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Chris Colman <ch...@stepaheadsoftware.com> on 2015/02/12 11:59:30 UTC
Error building wicket-6.19.0 from src
I get the following error when I try to compile the 6.19.0 source code:
[ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
'public java.util.List collect()' is now final
[ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
'public java.util.List collect(org.apache.wicket.feed
back.IFeedbackMessageFilter)' is now final
[ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
'public org.apache.wicket.feedback.FeedbackCollector
setIncludeSession(boolean)' is now final
[ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
'public org.apache.wicket.feedback.FeedbackCollector
setRecursive(boolean)' is now final
Any idea what could be causing this?
Regards,
Chris
RE: Error building wicket-6.19.0 from src
Posted by Chris Colman <ch...@stepaheadsoftware.com>.
No worries!
> -----Original Message-----
> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> Sent: Wednesday, 18 February 2015 6:31 PM
> To: users@wicket.apache.org
> Subject: Re: Error building wicket-6.19.0 from src
>
> Thanks!
> I've changed it to '/'. Works fine here (as expected).
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Tue, Feb 17, 2015 at 9:28 PM, Chris Colman
> <ch...@stepaheadsoftware.com>
> wrote:
>
> > Here's a solution to the clirr problem that should continue to work
on
> > OSes with a different slant (/) on life ;) (BTW all of our servers
are
> > Linux so we can slant both ways!)
> >
> > It seems that clirr expects to see a forward slash regardless of
whether
> > it's running on Linux or Windows so you can't use ${file.separator}
on
> > Windows because that will give clirr a backslash.
> >
> > Also... when clirr is running on windows it needs the precedeing **/
as
> > per the example on this page
> >
http://mojo.codehaus.org/clirr-maven-plugin/examples/ignored-differences
> > .html otherwise it never matches the specified file.
> >
> > So with both of these in mind the clirr className element should
look
> > like:
> >
> >
<className>**/org/apache/wicket/feedback/FeedbackCollector</className>
> >
> > to ensure it works on both Windows and *nix.
> >
> > Regards,
> > Chris
> >
> >
> > > -----Original Message-----
> > > From: Martin Grigorov [mailto:mgrigorov@apache.org]
> > > Sent: Saturday, 14 February 2015 7:35 AM
> > > To: users@wicket.apache.org
> > > Subject: Re: Error building wicket-6.19.0 from src
> > >
> > > I use to say "because Windows users decided to suffer themselves
(with
> > the
> > > decision to use Windows)" :-)
> > >
> > > If you find the reason and a solution then we would be happy to
apply
> > it
> > > (unless it breaks the less-problematic OS-es)
> > >
> > > Martin Grigorov
> > > Wicket Training and Consulting
> > > https://twitter.com/mtgrigorov
> > >
> > > On Fri, Feb 13, 2015 at 10:30 PM, Chris Colman
> > > <chrisc@stepaheadsoftware.com
> > > > wrote:
> > >
> > > > There is a comment about this issue in the parent pom.xml.
> > > >
> > > > For anyone else who gest this issue you can find the
> > clirr-maven-plugin
> > > > in the parent pom.xml and change failOnError to false to allow
the
> > build
> > > > to complete.
> > > >
> > > > <configuration>
> > > > <comparisonVersion>6.0.0</comparisonVersion>
> > > > <failOnError>false</failOnError>
> > > > <logResults>true</logResults>
> > > > <ignored>
> > > > <difference>
> > > > <!-- FeedbackCollector used to be final.
Now
> > it
> > > > is non-final and so all existing methods were made final to keep
> > them
> > > > non-overridable. However, clirr does not take into account the
class
> > > > going from final to non-final and thinks overridable methods
were
> > made
> > > > final. We ignore this change to silence it. -->
> > > >
> > > >
> >
<className>org${file.separator}apache${file.separator}wicket${file.separ
> > > > ator}feedback${file.separator}FeedbackCollector</className>
> > > > <method>*</method>
> > > > <differenceType>7014</differenceType>
> > > > </difference>
> > > > </ignored>
> > > > </configuration>
> > > >
> > > > I'm not sure why it's a Windows only problem when the plugin
config
> > is
> > > > using file.separator and not explicitly '/'
> > > >
> > > > > -----Original Message-----
> > > > > From: Tobias Soloschenko
[mailto:tobiassoloschenko@googlemail.com]
> > > > > Sent: Saturday, 14 February 2015 5:06 AM
> > > > > To: users@wicket.apache.org
> > > > > Subject: Re: Error building wicket-6.19.0 from src
> > > > >
> > > > > Hi,
> > > > >
> > > > > which Java Version are you using currently? There is an issue
of
> > the
> > > > > clirr plugin not to work with Java 8 at the moment. I filed in
a
> > > > ticket:
> > > > >
> > > > > https://issues.apache.org/jira/browse/WICKET-5836
> > > > >
> > > > > kind regards
> > > > >
> > > > > Tobias
> > > > >
> > > > > Am 13.02.15 um 18:43 schrieb Chris Colman:
> > > > > > I'm compiling on Windows 8.1 64bit if that makes any
difference.
> > > > > >
> > > > > > A few years ago there was an issue with clirr due to a
forward
> > > > > > slash/backslash issue which caused it to compile ok on
Linux/Mac
> > but
> > > > > > fail on Windows but I'm pretty sure that was resolved a long
> > time
> > > > ago.
> > > > > >
> > > > > > Regards,
> > > > > > Chris
> > > > > >
> > > > > >> -----Original Message-----
> > > > > >> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> > > > > >> Sent: Thursday, 12 February 2015 11:22 PM
> > > > > >> To: users@wicket.apache.org
> > > > > >> Subject: Re: Error building wicket-6.19.0 from src
> > > > > >>
> > > > > >> Hi,
> > > > > >>
> > > > > >> According to the SCM history [1] this class hasn't been
changed
> > > > since
> > > > > > Nov
> > > > > >> 26 2012.
> > > > > >>
> > > > > >>
> > > > > >> 1.
> > > > > >> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> > > > > >>
> > > >
core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
> > > > > >>
> > > > > >> Martin Grigorov
> > > > > >> Wicket Training and Consulting
> > > > > >> https://twitter.com/mtgrigorov
> > > > > >>
> > > > > >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> > > > > >> <chrisc@stepaheadsoftware.com
> > > > > >>> wrote:
> > > > > >>> I get the following error when I try to compile the 6.19.0
> > source
> > > > > > code:
> > > > > >>> [ERROR] 7014:
org.apache.wicket.feedback.FeedbackCollector:
> > > > Method
> > > > > >>> 'public java.util.List collect()' is now final
> > > > > >>> [ERROR] 7014:
org.apache.wicket.feedback.FeedbackCollector:
> > Method
> > > > > >>> 'public java.util.List collect(org.apache.wicket.feed
> > > > > >>> back.IFeedbackMessageFilter)' is now final
> > > > > >>> [ERROR] 7014:
org.apache.wicket.feedback.FeedbackCollector:
> > Method
> > > > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > > > >>> setIncludeSession(boolean)' is now final
> > > > > >>> [ERROR] 7014:
org.apache.wicket.feedback.FeedbackCollector:
> > Method
> > > > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > > > >>> setRecursive(boolean)' is now final
> > > > > >>>
> > > > > >>> Any idea what could be causing this?
> > > > > >>>
> > > > > >>> Regards,
> > > > > >>> Chris
> > > > > >>>
> > > > > >
> > > >
> >
---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > > > For additional commands, e-mail:
users-help@wicket.apache.org
> > > > > >
> > > > >
> > > > >
> > > > >
> >
---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > >
> > > >
> > > >
> >
---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > >
> > > >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Error building wicket-6.19.0 from src
Posted by Martin Grigorov <mg...@apache.org>.
Thanks!
I've changed it to '/'. Works fine here (as expected).
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Tue, Feb 17, 2015 at 9:28 PM, Chris Colman <ch...@stepaheadsoftware.com>
wrote:
> Here's a solution to the clirr problem that should continue to work on
> OSes with a different slant (/) on life ;) (BTW all of our servers are
> Linux so we can slant both ways!)
>
> It seems that clirr expects to see a forward slash regardless of whether
> it's running on Linux or Windows so you can't use ${file.separator} on
> Windows because that will give clirr a backslash.
>
> Also... when clirr is running on windows it needs the precedeing **/ as
> per the example on this page
> http://mojo.codehaus.org/clirr-maven-plugin/examples/ignored-differences
> .html otherwise it never matches the specified file.
>
> So with both of these in mind the clirr className element should look
> like:
>
> <className>**/org/apache/wicket/feedback/FeedbackCollector</className>
>
> to ensure it works on both Windows and *nix.
>
> Regards,
> Chris
>
>
> > -----Original Message-----
> > From: Martin Grigorov [mailto:mgrigorov@apache.org]
> > Sent: Saturday, 14 February 2015 7:35 AM
> > To: users@wicket.apache.org
> > Subject: Re: Error building wicket-6.19.0 from src
> >
> > I use to say "because Windows users decided to suffer themselves (with
> the
> > decision to use Windows)" :-)
> >
> > If you find the reason and a solution then we would be happy to apply
> it
> > (unless it breaks the less-problematic OS-es)
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Fri, Feb 13, 2015 at 10:30 PM, Chris Colman
> > <chrisc@stepaheadsoftware.com
> > > wrote:
> >
> > > There is a comment about this issue in the parent pom.xml.
> > >
> > > For anyone else who gest this issue you can find the
> clirr-maven-plugin
> > > in the parent pom.xml and change failOnError to false to allow the
> build
> > > to complete.
> > >
> > > <configuration>
> > > <comparisonVersion>6.0.0</comparisonVersion>
> > > <failOnError>false</failOnError>
> > > <logResults>true</logResults>
> > > <ignored>
> > > <difference>
> > > <!-- FeedbackCollector used to be final. Now
> it
> > > is non-final and so all existing methods were made final to keep
> them
> > > non-overridable. However, clirr does not take into account the class
> > > going from final to non-final and thinks overridable methods were
> made
> > > final. We ignore this change to silence it. -->
> > >
> > >
> <className>org${file.separator}apache${file.separator}wicket${file.separ
> > > ator}feedback${file.separator}FeedbackCollector</className>
> > > <method>*</method>
> > > <differenceType>7014</differenceType>
> > > </difference>
> > > </ignored>
> > > </configuration>
> > >
> > > I'm not sure why it's a Windows only problem when the plugin config
> is
> > > using file.separator and not explicitly '/'
> > >
> > > > -----Original Message-----
> > > > From: Tobias Soloschenko [mailto:tobiassoloschenko@googlemail.com]
> > > > Sent: Saturday, 14 February 2015 5:06 AM
> > > > To: users@wicket.apache.org
> > > > Subject: Re: Error building wicket-6.19.0 from src
> > > >
> > > > Hi,
> > > >
> > > > which Java Version are you using currently? There is an issue of
> the
> > > > clirr plugin not to work with Java 8 at the moment. I filed in a
> > > ticket:
> > > >
> > > > https://issues.apache.org/jira/browse/WICKET-5836
> > > >
> > > > kind regards
> > > >
> > > > Tobias
> > > >
> > > > Am 13.02.15 um 18:43 schrieb Chris Colman:
> > > > > I'm compiling on Windows 8.1 64bit if that makes any difference.
> > > > >
> > > > > A few years ago there was an issue with clirr due to a forward
> > > > > slash/backslash issue which caused it to compile ok on Linux/Mac
> but
> > > > > fail on Windows but I'm pretty sure that was resolved a long
> time
> > > ago.
> > > > >
> > > > > Regards,
> > > > > Chris
> > > > >
> > > > >> -----Original Message-----
> > > > >> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> > > > >> Sent: Thursday, 12 February 2015 11:22 PM
> > > > >> To: users@wicket.apache.org
> > > > >> Subject: Re: Error building wicket-6.19.0 from src
> > > > >>
> > > > >> Hi,
> > > > >>
> > > > >> According to the SCM history [1] this class hasn't been changed
> > > since
> > > > > Nov
> > > > >> 26 2012.
> > > > >>
> > > > >>
> > > > >> 1.
> > > > >> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> > > > >>
> > > core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
> > > > >>
> > > > >> Martin Grigorov
> > > > >> Wicket Training and Consulting
> > > > >> https://twitter.com/mtgrigorov
> > > > >>
> > > > >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> > > > >> <chrisc@stepaheadsoftware.com
> > > > >>> wrote:
> > > > >>> I get the following error when I try to compile the 6.19.0
> source
> > > > > code:
> > > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> > > Method
> > > > >>> 'public java.util.List collect()' is now final
> > > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
> > > > >>> 'public java.util.List collect(org.apache.wicket.feed
> > > > >>> back.IFeedbackMessageFilter)' is now final
> > > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
> > > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > > >>> setIncludeSession(boolean)' is now final
> > > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
> > > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > > >>> setRecursive(boolean)' is now final
> > > > >>>
> > > > >>> Any idea what could be causing this?
> > > > >>>
> > > > >>> Regards,
> > > > >>> Chris
> > > > >>>
> > > > >
> > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > > >
> > > >
> > > >
> > > >
> ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > For additional commands, e-mail: users-help@wicket.apache.org
> > >
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > For additional commands, e-mail: users-help@wicket.apache.org
> > >
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
Re: Error building wicket-6.19.0 from src
Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi,
thank you for sharing your solution. :-)
kind regards
Tobias
> Am 17.02.2015 um 20:28 schrieb Chris Colman <ch...@stepaheadsoftware.com>:
>
> Here's a solution to the clirr problem that should continue to work on
> OSes with a different slant (/) on life ;) (BTW all of our servers are
> Linux so we can slant both ways!)
>
> It seems that clirr expects to see a forward slash regardless of whether
> it's running on Linux or Windows so you can't use ${file.separator} on
> Windows because that will give clirr a backslash.
>
> Also... when clirr is running on windows it needs the precedeing **/ as
> per the example on this page
> http://mojo.codehaus.org/clirr-maven-plugin/examples/ignored-differences
> .html otherwise it never matches the specified file.
>
> So with both of these in mind the clirr className element should look
> like:
>
> <className>**/org/apache/wicket/feedback/FeedbackCollector</className>
>
> to ensure it works on both Windows and *nix.
>
> Regards,
> Chris
>
>
>> -----Original Message-----
>> From: Martin Grigorov [mailto:mgrigorov@apache.org]
>> Sent: Saturday, 14 February 2015 7:35 AM
>> To: users@wicket.apache.org
>> Subject: Re: Error building wicket-6.19.0 from src
>>
>> I use to say "because Windows users decided to suffer themselves (with
> the
>> decision to use Windows)" :-)
>>
>> If you find the reason and a solution then we would be happy to apply
> it
>> (unless it breaks the less-problematic OS-es)
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Fri, Feb 13, 2015 at 10:30 PM, Chris Colman
>> <chrisc@stepaheadsoftware.com
>>> wrote:
>>
>>> There is a comment about this issue in the parent pom.xml.
>>>
>>> For anyone else who gest this issue you can find the
> clirr-maven-plugin
>>> in the parent pom.xml and change failOnError to false to allow the
> build
>>> to complete.
>>>
>>> <configuration>
>>> <comparisonVersion>6.0.0</comparisonVersion>
>>> <failOnError>false</failOnError>
>>> <logResults>true</logResults>
>>> <ignored>
>>> <difference>
>>> <!-- FeedbackCollector used to be final. Now
> it
>>> is non-final and so all existing methods were made final to keep
> them
>>> non-overridable. However, clirr does not take into account the class
>>> going from final to non-final and thinks overridable methods were
> made
>>> final. We ignore this change to silence it. -->
> <className>org${file.separator}apache${file.separator}wicket${file.separ
>>> ator}feedback${file.separator}FeedbackCollector</className>
>>> <method>*</method>
>>> <differenceType>7014</differenceType>
>>> </difference>
>>> </ignored>
>>> </configuration>
>>>
>>> I'm not sure why it's a Windows only problem when the plugin config
> is
>>> using file.separator and not explicitly '/'
>>>
>>>> -----Original Message-----
>>>> From: Tobias Soloschenko [mailto:tobiassoloschenko@googlemail.com]
>>>> Sent: Saturday, 14 February 2015 5:06 AM
>>>> To: users@wicket.apache.org
>>>> Subject: Re: Error building wicket-6.19.0 from src
>>>>
>>>> Hi,
>>>>
>>>> which Java Version are you using currently? There is an issue of
> the
>>>> clirr plugin not to work with Java 8 at the moment. I filed in a
>>> ticket:
>>>>
>>>> https://issues.apache.org/jira/browse/WICKET-5836
>>>>
>>>> kind regards
>>>>
>>>> Tobias
>>>>
>>>>> Am 13.02.15 um 18:43 schrieb Chris Colman:
>>>>> I'm compiling on Windows 8.1 64bit if that makes any difference.
>>>>>
>>>>> A few years ago there was an issue with clirr due to a forward
>>>>> slash/backslash issue which caused it to compile ok on Linux/Mac
> but
>>>>> fail on Windows but I'm pretty sure that was resolved a long
> time
>>> ago.
>>>>>
>>>>> Regards,
>>>>> Chris
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Martin Grigorov [mailto:mgrigorov@apache.org]
>>>>>> Sent: Thursday, 12 February 2015 11:22 PM
>>>>>> To: users@wicket.apache.org
>>>>>> Subject: Re: Error building wicket-6.19.0 from src
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> According to the SCM history [1] this class hasn't been changed
>>> since
>>>>> Nov
>>>>>> 26 2012.
>>>>>>
>>>>>>
>>>>>> 1.
>>>>>> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
>>> core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
>>>>>>
>>>>>> Martin Grigorov
>>>>>> Wicket Training and Consulting
>>>>>> https://twitter.com/mtgrigorov
>>>>>>
>>>>>> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
>>>>>> <chrisc@stepaheadsoftware.com
>>>>>>> wrote:
>>>>>>> I get the following error when I try to compile the 6.19.0
> source
>>>>> code:
>>>>>>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
>>> Method
>>>>>>> 'public java.util.List collect()' is now final
>>>>>>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
>>>>>>> 'public java.util.List collect(org.apache.wicket.feed
>>>>>>> back.IFeedbackMessageFilter)' is now final
>>>>>>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
>>>>>>> 'public org.apache.wicket.feedback.FeedbackCollector
>>>>>>> setIncludeSession(boolean)' is now final
>>>>>>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
>>>>>>> 'public org.apache.wicket.feedback.FeedbackCollector
>>>>>>> setRecursive(boolean)' is now final
>>>>>>>
>>>>>>> Any idea what could be causing this?
>>>>>>>
>>>>>>> Regards,
>>>>>>> Chris
> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>>>> For additional commands, e-mail: users-help@wicket.apache.org
> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>>> For additional commands, e-mail: users-help@wicket.apache.org
> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail: users-help@wicket.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
RE: Error building wicket-6.19.0 from src
Posted by Chris Colman <ch...@stepaheadsoftware.com>.
Here's a solution to the clirr problem that should continue to work on
OSes with a different slant (/) on life ;) (BTW all of our servers are
Linux so we can slant both ways!)
It seems that clirr expects to see a forward slash regardless of whether
it's running on Linux or Windows so you can't use ${file.separator} on
Windows because that will give clirr a backslash.
Also... when clirr is running on windows it needs the precedeing **/ as
per the example on this page
http://mojo.codehaus.org/clirr-maven-plugin/examples/ignored-differences
.html otherwise it never matches the specified file.
So with both of these in mind the clirr className element should look
like:
<className>**/org/apache/wicket/feedback/FeedbackCollector</className>
to ensure it works on both Windows and *nix.
Regards,
Chris
> -----Original Message-----
> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> Sent: Saturday, 14 February 2015 7:35 AM
> To: users@wicket.apache.org
> Subject: Re: Error building wicket-6.19.0 from src
>
> I use to say "because Windows users decided to suffer themselves (with
the
> decision to use Windows)" :-)
>
> If you find the reason and a solution then we would be happy to apply
it
> (unless it breaks the less-problematic OS-es)
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Fri, Feb 13, 2015 at 10:30 PM, Chris Colman
> <chrisc@stepaheadsoftware.com
> > wrote:
>
> > There is a comment about this issue in the parent pom.xml.
> >
> > For anyone else who gest this issue you can find the
clirr-maven-plugin
> > in the parent pom.xml and change failOnError to false to allow the
build
> > to complete.
> >
> > <configuration>
> > <comparisonVersion>6.0.0</comparisonVersion>
> > <failOnError>false</failOnError>
> > <logResults>true</logResults>
> > <ignored>
> > <difference>
> > <!-- FeedbackCollector used to be final. Now
it
> > is non-final and so all existing methods were made final to keep
them
> > non-overridable. However, clirr does not take into account the class
> > going from final to non-final and thinks overridable methods were
made
> > final. We ignore this change to silence it. -->
> >
> >
<className>org${file.separator}apache${file.separator}wicket${file.separ
> > ator}feedback${file.separator}FeedbackCollector</className>
> > <method>*</method>
> > <differenceType>7014</differenceType>
> > </difference>
> > </ignored>
> > </configuration>
> >
> > I'm not sure why it's a Windows only problem when the plugin config
is
> > using file.separator and not explicitly '/'
> >
> > > -----Original Message-----
> > > From: Tobias Soloschenko [mailto:tobiassoloschenko@googlemail.com]
> > > Sent: Saturday, 14 February 2015 5:06 AM
> > > To: users@wicket.apache.org
> > > Subject: Re: Error building wicket-6.19.0 from src
> > >
> > > Hi,
> > >
> > > which Java Version are you using currently? There is an issue of
the
> > > clirr plugin not to work with Java 8 at the moment. I filed in a
> > ticket:
> > >
> > > https://issues.apache.org/jira/browse/WICKET-5836
> > >
> > > kind regards
> > >
> > > Tobias
> > >
> > > Am 13.02.15 um 18:43 schrieb Chris Colman:
> > > > I'm compiling on Windows 8.1 64bit if that makes any difference.
> > > >
> > > > A few years ago there was an issue with clirr due to a forward
> > > > slash/backslash issue which caused it to compile ok on Linux/Mac
but
> > > > fail on Windows but I'm pretty sure that was resolved a long
time
> > ago.
> > > >
> > > > Regards,
> > > > Chris
> > > >
> > > >> -----Original Message-----
> > > >> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> > > >> Sent: Thursday, 12 February 2015 11:22 PM
> > > >> To: users@wicket.apache.org
> > > >> Subject: Re: Error building wicket-6.19.0 from src
> > > >>
> > > >> Hi,
> > > >>
> > > >> According to the SCM history [1] this class hasn't been changed
> > since
> > > > Nov
> > > >> 26 2012.
> > > >>
> > > >>
> > > >> 1.
> > > >> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> > > >>
> > core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
> > > >>
> > > >> Martin Grigorov
> > > >> Wicket Training and Consulting
> > > >> https://twitter.com/mtgrigorov
> > > >>
> > > >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> > > >> <chrisc@stepaheadsoftware.com
> > > >>> wrote:
> > > >>> I get the following error when I try to compile the 6.19.0
source
> > > > code:
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> > Method
> > > >>> 'public java.util.List collect()' is now final
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> > > >>> 'public java.util.List collect(org.apache.wicket.feed
> > > >>> back.IFeedbackMessageFilter)' is now final
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > >>> setIncludeSession(boolean)' is now final
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > >>> setRecursive(boolean)' is now final
> > > >>>
> > > >>> Any idea what could be causing this?
> > > >>>
> > > >>> Regards,
> > > >>> Chris
> > > >>>
> > > >
> >
---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > >
> > >
> > >
> > >
---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > For additional commands, e-mail: users-help@wicket.apache.org
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Error building wicket-6.19.0 from src
Posted by Martin Grigorov <mg...@apache.org>.
I use to say "because Windows users decided to suffer themselves (with the
decision to use Windows)" :-)
If you find the reason and a solution then we would be happy to apply it
(unless it breaks the less-problematic OS-es)
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Fri, Feb 13, 2015 at 10:30 PM, Chris Colman <chrisc@stepaheadsoftware.com
> wrote:
> There is a comment about this issue in the parent pom.xml.
>
> For anyone else who gest this issue you can find the clirr-maven-plugin
> in the parent pom.xml and change failOnError to false to allow the build
> to complete.
>
> <configuration>
> <comparisonVersion>6.0.0</comparisonVersion>
> <failOnError>false</failOnError>
> <logResults>true</logResults>
> <ignored>
> <difference>
> <!-- FeedbackCollector used to be final. Now it
> is non-final and so all existing methods were made final to keep them
> non-overridable. However, clirr does not take into account the class
> going from final to non-final and thinks overridable methods were made
> final. We ignore this change to silence it. -->
>
> <className>org${file.separator}apache${file.separator}wicket${file.separ
> ator}feedback${file.separator}FeedbackCollector</className>
> <method>*</method>
> <differenceType>7014</differenceType>
> </difference>
> </ignored>
> </configuration>
>
> I'm not sure why it's a Windows only problem when the plugin config is
> using file.separator and not explicitly '/'
>
> > -----Original Message-----
> > From: Tobias Soloschenko [mailto:tobiassoloschenko@googlemail.com]
> > Sent: Saturday, 14 February 2015 5:06 AM
> > To: users@wicket.apache.org
> > Subject: Re: Error building wicket-6.19.0 from src
> >
> > Hi,
> >
> > which Java Version are you using currently? There is an issue of the
> > clirr plugin not to work with Java 8 at the moment. I filed in a
> ticket:
> >
> > https://issues.apache.org/jira/browse/WICKET-5836
> >
> > kind regards
> >
> > Tobias
> >
> > Am 13.02.15 um 18:43 schrieb Chris Colman:
> > > I'm compiling on Windows 8.1 64bit if that makes any difference.
> > >
> > > A few years ago there was an issue with clirr due to a forward
> > > slash/backslash issue which caused it to compile ok on Linux/Mac but
> > > fail on Windows but I'm pretty sure that was resolved a long time
> ago.
> > >
> > > Regards,
> > > Chris
> > >
> > >> -----Original Message-----
> > >> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> > >> Sent: Thursday, 12 February 2015 11:22 PM
> > >> To: users@wicket.apache.org
> > >> Subject: Re: Error building wicket-6.19.0 from src
> > >>
> > >> Hi,
> > >>
> > >> According to the SCM history [1] this class hasn't been changed
> since
> > > Nov
> > >> 26 2012.
> > >>
> > >>
> > >> 1.
> > >> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> > >>
> core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
> > >>
> > >> Martin Grigorov
> > >> Wicket Training and Consulting
> > >> https://twitter.com/mtgrigorov
> > >>
> > >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> > >> <chrisc@stepaheadsoftware.com
> > >>> wrote:
> > >>> I get the following error when I try to compile the 6.19.0 source
> > > code:
> > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
> > >>> 'public java.util.List collect()' is now final
> > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > >>> 'public java.util.List collect(org.apache.wicket.feed
> > >>> back.IFeedbackMessageFilter)' is now final
> > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > >>> setIncludeSession(boolean)' is now final
> > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > >>> setRecursive(boolean)' is now final
> > >>>
> > >>> Any idea what could be causing this?
> > >>>
> > >>> Regards,
> > >>> Chris
> > >>>
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > For additional commands, e-mail: users-help@wicket.apache.org
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
RE: Error building wicket-6.19.0 from src
Posted by Chris Colman <ch...@stepaheadsoftware.com>.
I'm trying to build wicket itself, not application code.
The errors are:
[INFO] <<< clirr-maven-plugin:2.6.1:check (clirr-check) @ wicket-core
<<<
[INFO]
[INFO] --- clirr-maven-plugin:2.6.1:check (clirr-check) @ wicket-core
---
[INFO] Comparing to version: 6.0.0
[ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
'public java.util.List collect()' is now final
[ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
'public java.util.List
collect(org.apache.wicket.feedback.IFeedbackMessageFilter)' is now final
[ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
'public org.apache.wicket.feedback.FeedbackCollector
setIncludeSession(boolean)' is now final
[ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
'public org.apache.wicket.feedback.FeedbackCollector
setRecursive(boolean)' is now final
[WARNING] 6003:
org.apache.wicket.markup.parser.filter.InlineEnclosureHandler: Value of
compile-time constant INLINE_ENCLOSURE_ATTRIBUTE_NAME has been changed
[INFO] Succeeded with 4 errors; 1 warnings; and 0 other changes.
[INFO]
> -----Original Message-----
> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> Sent: Saturday, 14 February 2015 7:29 AM
> To: users@wicket.apache.org
> Subject: Re: Error building wicket-6.19.0 from src
>
> Please give more details what you are doing.
> Where exactly it breaks.
>
> Error like:
> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> 'public java.util.List collect()' is now final
> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
>
> means that some application code tries to override this method. I.e.
you
> try to build the application code, not Wicket itself.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Fri, Feb 13, 2015 at 10:18 PM, Chris Colman
> <chrisc@stepaheadsoftware.com
> > wrote:
>
> > Unfortunately that wasn't it!
> >
> > I uninstalled Java 1.8 and reverted to Java 1.7.0_55 and the same
> > problem occurs.
> >
> > I switched to the 6.x branch (currently 6.20.0) and it still occurs.
> >
> > > -----Original Message-----
> > > From: Chris Colman [mailto:chrisc@stepaheadsoftware.com]
> > > Sent: Saturday, 14 February 2015 5:39 AM
> > > To: users@wicket.apache.org
> > > Subject: RE: Error building wicket-6.19.0 from src
> > >
> > > Ah bingo! That's probably it. I'm using:
> > >
> > > java version "1.8.0_25"
> > > Java(TM) SE Runtime Environment (build 1.8.0_25-b18)
> > > Java HotSpot(TM) Client VM (build 25.25-b02, mixed mode)
> > >
> > >
> > > > -----Original Message-----
> > > > From: Tobias Soloschenko
[mailto:tobiassoloschenko@googlemail.com]
> > > > Sent: Saturday, 14 February 2015 5:06 AM
> > > > To: users@wicket.apache.org
> > > > Subject: Re: Error building wicket-6.19.0 from src
> > > >
> > > > Hi,
> > > >
> > > > which Java Version are you using currently? There is an issue of
the
> > > > clirr plugin not to work with Java 8 at the moment. I filed in a
> > > ticket:
> > > >
> > > > https://issues.apache.org/jira/browse/WICKET-5836
> > > >
> > > > kind regards
> > > >
> > > > Tobias
> > > >
> > > > Am 13.02.15 um 18:43 schrieb Chris Colman:
> > > > > I'm compiling on Windows 8.1 64bit if that makes any
difference.
> > > > >
> > > > > A few years ago there was an issue with clirr due to a forward
> > > > > slash/backslash issue which caused it to compile ok on
Linux/Mac
> > but
> > > > > fail on Windows but I'm pretty sure that was resolved a long
time
> > > ago.
> > > > >
> > > > > Regards,
> > > > > Chris
> > > > >
> > > > >> -----Original Message-----
> > > > >> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> > > > >> Sent: Thursday, 12 February 2015 11:22 PM
> > > > >> To: users@wicket.apache.org
> > > > >> Subject: Re: Error building wicket-6.19.0 from src
> > > > >>
> > > > >> Hi,
> > > > >>
> > > > >> According to the SCM history [1] this class hasn't been
changed
> > > since
> > > > > Nov
> > > > >> 26 2012.
> > > > >>
> > > > >>
> > > > >> 1.
> > > > >> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> > > > >>
> > >
core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
> > > > >>
> > > > >> Martin Grigorov
> > > > >> Wicket Training and Consulting
> > > > >> https://twitter.com/mtgrigorov
> > > > >>
> > > > >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> > > > >> <chrisc@stepaheadsoftware.com
> > > > >>> wrote:
> > > > >>> I get the following error when I try to compile the 6.19.0
> > source
> > > > > code:
> > > > >>> [ERROR] 7014:
org.apache.wicket.feedback.FeedbackCollector:
> > > Method
> > > > >>> 'public java.util.List collect()' is now final
> > > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> > Method
> > > > >>> 'public java.util.List collect(org.apache.wicket.feed
> > > > >>> back.IFeedbackMessageFilter)' is now final
> > > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> > Method
> > > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > > >>> setIncludeSession(boolean)' is now final
> > > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> > Method
> > > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > > >>> setRecursive(boolean)' is now final
> > > > >>>
> > > > >>> Any idea what could be causing this?
> > > > >>>
> > > > >>> Regards,
> > > > >>> Chris
> > > > >>>
> > > > >
> > >
---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > > >
> > > >
> > > >
> > > >
> >
---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > For additional commands, e-mail: users-help@wicket.apache.org
> > >
> > >
> > >
---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > For additional commands, e-mail: users-help@wicket.apache.org
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Error building wicket-6.19.0 from src
Posted by Martin Grigorov <mg...@apache.org>.
Please give more details what you are doing.
Where exactly it breaks.
Error like:
[ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
'public java.util.List collect()' is now final
[ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
means that some application code tries to override this method. I.e. you
try to build the application code, not Wicket itself.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Fri, Feb 13, 2015 at 10:18 PM, Chris Colman <chrisc@stepaheadsoftware.com
> wrote:
> Unfortunately that wasn't it!
>
> I uninstalled Java 1.8 and reverted to Java 1.7.0_55 and the same
> problem occurs.
>
> I switched to the 6.x branch (currently 6.20.0) and it still occurs.
>
> > -----Original Message-----
> > From: Chris Colman [mailto:chrisc@stepaheadsoftware.com]
> > Sent: Saturday, 14 February 2015 5:39 AM
> > To: users@wicket.apache.org
> > Subject: RE: Error building wicket-6.19.0 from src
> >
> > Ah bingo! That's probably it. I'm using:
> >
> > java version "1.8.0_25"
> > Java(TM) SE Runtime Environment (build 1.8.0_25-b18)
> > Java HotSpot(TM) Client VM (build 25.25-b02, mixed mode)
> >
> >
> > > -----Original Message-----
> > > From: Tobias Soloschenko [mailto:tobiassoloschenko@googlemail.com]
> > > Sent: Saturday, 14 February 2015 5:06 AM
> > > To: users@wicket.apache.org
> > > Subject: Re: Error building wicket-6.19.0 from src
> > >
> > > Hi,
> > >
> > > which Java Version are you using currently? There is an issue of the
> > > clirr plugin not to work with Java 8 at the moment. I filed in a
> > ticket:
> > >
> > > https://issues.apache.org/jira/browse/WICKET-5836
> > >
> > > kind regards
> > >
> > > Tobias
> > >
> > > Am 13.02.15 um 18:43 schrieb Chris Colman:
> > > > I'm compiling on Windows 8.1 64bit if that makes any difference.
> > > >
> > > > A few years ago there was an issue with clirr due to a forward
> > > > slash/backslash issue which caused it to compile ok on Linux/Mac
> but
> > > > fail on Windows but I'm pretty sure that was resolved a long time
> > ago.
> > > >
> > > > Regards,
> > > > Chris
> > > >
> > > >> -----Original Message-----
> > > >> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> > > >> Sent: Thursday, 12 February 2015 11:22 PM
> > > >> To: users@wicket.apache.org
> > > >> Subject: Re: Error building wicket-6.19.0 from src
> > > >>
> > > >> Hi,
> > > >>
> > > >> According to the SCM history [1] this class hasn't been changed
> > since
> > > > Nov
> > > >> 26 2012.
> > > >>
> > > >>
> > > >> 1.
> > > >> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> > > >>
> > core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
> > > >>
> > > >> Martin Grigorov
> > > >> Wicket Training and Consulting
> > > >> https://twitter.com/mtgrigorov
> > > >>
> > > >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> > > >> <chrisc@stepaheadsoftware.com
> > > >>> wrote:
> > > >>> I get the following error when I try to compile the 6.19.0
> source
> > > > code:
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> > Method
> > > >>> 'public java.util.List collect()' is now final
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
> > > >>> 'public java.util.List collect(org.apache.wicket.feed
> > > >>> back.IFeedbackMessageFilter)' is now final
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
> > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > >>> setIncludeSession(boolean)' is now final
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
> > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > >>> setRecursive(boolean)' is now final
> > > >>>
> > > >>> Any idea what could be causing this?
> > > >>>
> > > >>> Regards,
> > > >>> Chris
> > > >>>
> > > >
> > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > >
> > >
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > For additional commands, e-mail: users-help@wicket.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
RE: Error building wicket-6.19.0 from src
Posted by Chris Colman <ch...@stepaheadsoftware.com>.
Unfortunately that wasn't it!
I uninstalled Java 1.8 and reverted to Java 1.7.0_55 and the same
problem occurs.
I switched to the 6.x branch (currently 6.20.0) and it still occurs.
> -----Original Message-----
> From: Chris Colman [mailto:chrisc@stepaheadsoftware.com]
> Sent: Saturday, 14 February 2015 5:39 AM
> To: users@wicket.apache.org
> Subject: RE: Error building wicket-6.19.0 from src
>
> Ah bingo! That's probably it. I'm using:
>
> java version "1.8.0_25"
> Java(TM) SE Runtime Environment (build 1.8.0_25-b18)
> Java HotSpot(TM) Client VM (build 25.25-b02, mixed mode)
>
>
> > -----Original Message-----
> > From: Tobias Soloschenko [mailto:tobiassoloschenko@googlemail.com]
> > Sent: Saturday, 14 February 2015 5:06 AM
> > To: users@wicket.apache.org
> > Subject: Re: Error building wicket-6.19.0 from src
> >
> > Hi,
> >
> > which Java Version are you using currently? There is an issue of the
> > clirr plugin not to work with Java 8 at the moment. I filed in a
> ticket:
> >
> > https://issues.apache.org/jira/browse/WICKET-5836
> >
> > kind regards
> >
> > Tobias
> >
> > Am 13.02.15 um 18:43 schrieb Chris Colman:
> > > I'm compiling on Windows 8.1 64bit if that makes any difference.
> > >
> > > A few years ago there was an issue with clirr due to a forward
> > > slash/backslash issue which caused it to compile ok on Linux/Mac
but
> > > fail on Windows but I'm pretty sure that was resolved a long time
> ago.
> > >
> > > Regards,
> > > Chris
> > >
> > >> -----Original Message-----
> > >> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> > >> Sent: Thursday, 12 February 2015 11:22 PM
> > >> To: users@wicket.apache.org
> > >> Subject: Re: Error building wicket-6.19.0 from src
> > >>
> > >> Hi,
> > >>
> > >> According to the SCM history [1] this class hasn't been changed
> since
> > > Nov
> > >> 26 2012.
> > >>
> > >>
> > >> 1.
> > >> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> > >>
> core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
> > >>
> > >> Martin Grigorov
> > >> Wicket Training and Consulting
> > >> https://twitter.com/mtgrigorov
> > >>
> > >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> > >> <chrisc@stepaheadsoftware.com
> > >>> wrote:
> > >>> I get the following error when I try to compile the 6.19.0
source
> > > code:
> > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> Method
> > >>> 'public java.util.List collect()' is now final
> > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> > >>> 'public java.util.List collect(org.apache.wicket.feed
> > >>> back.IFeedbackMessageFilter)' is now final
> > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > >>> setIncludeSession(boolean)' is now final
> > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > >>> setRecursive(boolean)' is now final
> > >>>
> > >>> Any idea what could be causing this?
> > >>>
> > >>> Regards,
> > >>> Chris
> > >>>
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > For additional commands, e-mail: users-help@wicket.apache.org
> > >
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
RE: Error building wicket-6.19.0 from src
Posted by Chris Colman <ch...@stepaheadsoftware.com>.
Ah bingo! That's probably it. I'm using:
java version "1.8.0_25"
Java(TM) SE Runtime Environment (build 1.8.0_25-b18)
Java HotSpot(TM) Client VM (build 25.25-b02, mixed mode)
> -----Original Message-----
> From: Tobias Soloschenko [mailto:tobiassoloschenko@googlemail.com]
> Sent: Saturday, 14 February 2015 5:06 AM
> To: users@wicket.apache.org
> Subject: Re: Error building wicket-6.19.0 from src
>
> Hi,
>
> which Java Version are you using currently? There is an issue of the
> clirr plugin not to work with Java 8 at the moment. I filed in a
ticket:
>
> https://issues.apache.org/jira/browse/WICKET-5836
>
> kind regards
>
> Tobias
>
> Am 13.02.15 um 18:43 schrieb Chris Colman:
> > I'm compiling on Windows 8.1 64bit if that makes any difference.
> >
> > A few years ago there was an issue with clirr due to a forward
> > slash/backslash issue which caused it to compile ok on Linux/Mac but
> > fail on Windows but I'm pretty sure that was resolved a long time
ago.
> >
> > Regards,
> > Chris
> >
> >> -----Original Message-----
> >> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> >> Sent: Thursday, 12 February 2015 11:22 PM
> >> To: users@wicket.apache.org
> >> Subject: Re: Error building wicket-6.19.0 from src
> >>
> >> Hi,
> >>
> >> According to the SCM history [1] this class hasn't been changed
since
> > Nov
> >> 26 2012.
> >>
> >>
> >> 1.
> >> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> >>
core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
> >>
> >> Martin Grigorov
> >> Wicket Training and Consulting
> >> https://twitter.com/mtgrigorov
> >>
> >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> >> <chrisc@stepaheadsoftware.com
> >>> wrote:
> >>> I get the following error when I try to compile the 6.19.0 source
> > code:
> >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> >>> 'public java.util.List collect()' is now final
> >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> >>> 'public java.util.List collect(org.apache.wicket.feed
> >>> back.IFeedbackMessageFilter)' is now final
> >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> >>> 'public org.apache.wicket.feedback.FeedbackCollector
> >>> setIncludeSession(boolean)' is now final
> >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> >>> 'public org.apache.wicket.feedback.FeedbackCollector
> >>> setRecursive(boolean)' is now final
> >>>
> >>> Any idea what could be causing this?
> >>>
> >>> Regards,
> >>> Chris
> >>>
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
RE: Error building wicket-6.19.0 from src
Posted by Chris Colman <ch...@stepaheadsoftware.com>.
There is a comment about this issue in the parent pom.xml.
For anyone else who gest this issue you can find the clirr-maven-plugin
in the parent pom.xml and change failOnError to false to allow the build
to complete.
<configuration>
<comparisonVersion>6.0.0</comparisonVersion>
<failOnError>false</failOnError>
<logResults>true</logResults>
<ignored>
<difference>
<!-- FeedbackCollector used to be final. Now it
is non-final and so all existing methods were made final to keep them
non-overridable. However, clirr does not take into account the class
going from final to non-final and thinks overridable methods were made
final. We ignore this change to silence it. -->
<className>org${file.separator}apache${file.separator}wicket${file.separ
ator}feedback${file.separator}FeedbackCollector</className>
<method>*</method>
<differenceType>7014</differenceType>
</difference>
</ignored>
</configuration>
I'm not sure why it's a Windows only problem when the plugin config is
using file.separator and not explicitly '/'
> -----Original Message-----
> From: Tobias Soloschenko [mailto:tobiassoloschenko@googlemail.com]
> Sent: Saturday, 14 February 2015 5:06 AM
> To: users@wicket.apache.org
> Subject: Re: Error building wicket-6.19.0 from src
>
> Hi,
>
> which Java Version are you using currently? There is an issue of the
> clirr plugin not to work with Java 8 at the moment. I filed in a
ticket:
>
> https://issues.apache.org/jira/browse/WICKET-5836
>
> kind regards
>
> Tobias
>
> Am 13.02.15 um 18:43 schrieb Chris Colman:
> > I'm compiling on Windows 8.1 64bit if that makes any difference.
> >
> > A few years ago there was an issue with clirr due to a forward
> > slash/backslash issue which caused it to compile ok on Linux/Mac but
> > fail on Windows but I'm pretty sure that was resolved a long time
ago.
> >
> > Regards,
> > Chris
> >
> >> -----Original Message-----
> >> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> >> Sent: Thursday, 12 February 2015 11:22 PM
> >> To: users@wicket.apache.org
> >> Subject: Re: Error building wicket-6.19.0 from src
> >>
> >> Hi,
> >>
> >> According to the SCM history [1] this class hasn't been changed
since
> > Nov
> >> 26 2012.
> >>
> >>
> >> 1.
> >> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> >>
core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
> >>
> >> Martin Grigorov
> >> Wicket Training and Consulting
> >> https://twitter.com/mtgrigorov
> >>
> >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> >> <chrisc@stepaheadsoftware.com
> >>> wrote:
> >>> I get the following error when I try to compile the 6.19.0 source
> > code:
> >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> >>> 'public java.util.List collect()' is now final
> >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> >>> 'public java.util.List collect(org.apache.wicket.feed
> >>> back.IFeedbackMessageFilter)' is now final
> >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> >>> 'public org.apache.wicket.feedback.FeedbackCollector
> >>> setIncludeSession(boolean)' is now final
> >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> >>> 'public org.apache.wicket.feedback.FeedbackCollector
> >>> setRecursive(boolean)' is now final
> >>>
> >>> Any idea what could be causing this?
> >>>
> >>> Regards,
> >>> Chris
> >>>
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Error building wicket-6.19.0 from src
Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi,
which Java Version are you using currently? There is an issue of the
clirr plugin not to work with Java 8 at the moment. I filed in a ticket:
https://issues.apache.org/jira/browse/WICKET-5836
kind regards
Tobias
Am 13.02.15 um 18:43 schrieb Chris Colman:
> I'm compiling on Windows 8.1 64bit if that makes any difference.
>
> A few years ago there was an issue with clirr due to a forward
> slash/backslash issue which caused it to compile ok on Linux/Mac but
> fail on Windows but I'm pretty sure that was resolved a long time ago.
>
> Regards,
> Chris
>
>> -----Original Message-----
>> From: Martin Grigorov [mailto:mgrigorov@apache.org]
>> Sent: Thursday, 12 February 2015 11:22 PM
>> To: users@wicket.apache.org
>> Subject: Re: Error building wicket-6.19.0 from src
>>
>> Hi,
>>
>> According to the SCM history [1] this class hasn't been changed since
> Nov
>> 26 2012.
>>
>>
>> 1.
>> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
>> core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
>> <chrisc@stepaheadsoftware.com
>>> wrote:
>>> I get the following error when I try to compile the 6.19.0 source
> code:
>>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
>>> 'public java.util.List collect()' is now final
>>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
>>> 'public java.util.List collect(org.apache.wicket.feed
>>> back.IFeedbackMessageFilter)' is now final
>>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
>>> 'public org.apache.wicket.feedback.FeedbackCollector
>>> setIncludeSession(boolean)' is now final
>>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
>>> 'public org.apache.wicket.feedback.FeedbackCollector
>>> setRecursive(boolean)' is now final
>>>
>>> Any idea what could be causing this?
>>>
>>> Regards,
>>> Chris
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
RE: Error building wicket-6.19.0 from src
Posted by Chris Colman <ch...@stepaheadsoftware.com>.
I'm compiling on Windows 8.1 64bit if that makes any difference.
A few years ago there was an issue with clirr due to a forward
slash/backslash issue which caused it to compile ok on Linux/Mac but
fail on Windows but I'm pretty sure that was resolved a long time ago.
Regards,
Chris
> -----Original Message-----
> From: Martin Grigorov [mailto:mgrigorov@apache.org]
> Sent: Thursday, 12 February 2015 11:22 PM
> To: users@wicket.apache.org
> Subject: Re: Error building wicket-6.19.0 from src
>
> Hi,
>
> According to the SCM history [1] this class hasn't been changed since
Nov
> 26 2012.
>
>
> 1.
> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> <chrisc@stepaheadsoftware.com
> > wrote:
>
> > I get the following error when I try to compile the 6.19.0 source
code:
> >
> > [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > 'public java.util.List collect()' is now final
> > [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > 'public java.util.List collect(org.apache.wicket.feed
> > back.IFeedbackMessageFilter)' is now final
> > [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > 'public org.apache.wicket.feedback.FeedbackCollector
> > setIncludeSession(boolean)' is now final
> > [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > 'public org.apache.wicket.feedback.FeedbackCollector
> > setRecursive(boolean)' is now final
> >
> > Any idea what could be causing this?
> >
> > Regards,
> > Chris
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Error building wicket-6.19.0 from src
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
According to the SCM history [1] this class hasn't been changed since Nov
26 2012.
1.
https://github.com/apache/wicket/commits/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman <chrisc@stepaheadsoftware.com
> wrote:
> I get the following error when I try to compile the 6.19.0 source code:
>
> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> 'public java.util.List collect()' is now final
> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> 'public java.util.List collect(org.apache.wicket.feed
> back.IFeedbackMessageFilter)' is now final
> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> 'public org.apache.wicket.feedback.FeedbackCollector
> setIncludeSession(boolean)' is now final
> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> 'public org.apache.wicket.feedback.FeedbackCollector
> setRecursive(boolean)' is now final
>
> Any idea what could be causing this?
>
> Regards,
> Chris
>
RE: Error building wicket-6.19.0 from src
Posted by Chris Colman <ch...@stepaheadsoftware.com>.
I pulled it from git.
I'm trying to compile while on the 6.19.0 branch.
Regards,
Chris
> -----Original Message-----
> From: Andrea Del Bene [mailto:an.delbene@gmail.com]
> Sent: Thursday, 12 February 2015 11:21 PM
> To: users@wicket.apache.org
> Subject: Re: Error building wicket-6.19.0 from src
>
> Hi,
>
> how did you get the code ? did you download it or did you use the
6.19.0
> branch? I've tested the source from distribution
> (http://www.apache.org/dyn/closer.cgi/wicket/6.19.0) and everything
it's
> fine. These method are final since a long time...
> > I get the following error when I try to compile the 6.19.0 source
code:
> >
> > [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > 'public java.util.List collect()' is now final
> > [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > 'public java.util.List collect(org.apache.wicket.feed
> > back.IFeedbackMessageFilter)' is now final
> > [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > 'public org.apache.wicket.feedback.FeedbackCollector
> > setIncludeSession(boolean)' is now final
> > [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> > 'public org.apache.wicket.feedback.FeedbackCollector
> > setRecursive(boolean)' is now final
> >
> > Any idea what could be causing this?
> >
> > Regards,
> > Chris
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Error building wicket-6.19.0 from src
Posted by Andrea Del Bene <an...@gmail.com>.
Hi,
how did you get the code ? did you download it or did you use the 6.19.0
branch? I've tested the source from distribution
(http://www.apache.org/dyn/closer.cgi/wicket/6.19.0) and everything it's
fine. These method are final since a long time...
> I get the following error when I try to compile the 6.19.0 source code:
>
> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> 'public java.util.List collect()' is now final
> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> 'public java.util.List collect(org.apache.wicket.feed
> back.IFeedbackMessageFilter)' is now final
> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> 'public org.apache.wicket.feedback.FeedbackCollector
> setIncludeSession(boolean)' is now final
> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method
> 'public org.apache.wicket.feedback.FeedbackCollector
> setRecursive(boolean)' is now final
>
> Any idea what could be causing this?
>
> Regards,
> Chris
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org