You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/24 15:14:26 UTC

[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request, #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

SteNicholas opened a new pull request, #243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/243

   Flink kubernetes operator docker image could not build with source release at present. The `.git` directory should be copied when the directory exists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 merged pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

Posted by GitBox <gi...@apache.org>.
wangyang0918 merged PR #243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880655702


##########
Dockerfile:
##########
@@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/
 COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src
 COPY $WEBHOOK_DIR/src ./$WEBHOOK_DIR/src
 
-COPY .git ./.git
+COPY *.git ./.git

Review Comment:
   @tisonkun, I have removed the `.git` directory and built image successfully. The change will copy the `.git` directory when the directory exists and not copy this directory when the `.git` directory doesn't exist.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] tisonkun commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880649631


##########
Dockerfile:
##########
@@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/
 COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src
 COPY $WEBHOOK_DIR/src ./$WEBHOOK_DIR/src
 
-COPY .git ./.git
+COPY *.git ./.git

Review Comment:
   I'm unsure whether this line can possibly pollute unexpected files. At least we should add a comment about this tricky - it's a workaround since Dockerfile doesn't support conditional copy directly. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] tisonkun commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880657077


##########
Dockerfile:
##########
@@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/
 COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src
 COPY $WEBHOOK_DIR/src ./$WEBHOOK_DIR/src
 
-COPY .git ./.git
+COPY *.git ./.git

Review Comment:
   I confirm that this patch works also. My comment above is not about correctness - it's about documenting the trick.



##########
Dockerfile:
##########
@@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/
 COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src
 COPY $WEBHOOK_DIR/src ./$WEBHOOK_DIR/src
 
-COPY .git ./.git
+COPY *.git ./.git

Review Comment:
   I'm unsure whether this line can possibly pollute unexpected files. At least we should add a comment about this trick - it's a workaround since Dockerfile doesn't support conditional copy directly. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880660035


##########
Dockerfile:
##########
@@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/
 COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src
 COPY $WEBHOOK_DIR/src ./$WEBHOOK_DIR/src
 
-COPY .git ./.git
+COPY *.git ./.git

Review Comment:
   @tisonkun, sorry for the misunderstanding. I have addressed your comment to add a comment about this trick.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] tisonkun commented on pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/243#issuecomment-1136209005

   @wangyang0918 I'm thinking of `COPY . .` with a `.dockerignore` file. But yes, we can investigate better way after release 1.0.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] tisonkun commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880657077


##########
Dockerfile:
##########
@@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/
 COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src
 COPY $WEBHOOK_DIR/src ./$WEBHOOK_DIR/src
 
-COPY .git ./.git
+COPY *.git ./.git

Review Comment:
   I confirm that this patch works also. My comment above is not about correctness - it's about documenting the tricky.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/243#issuecomment-1136640871

   I have created a new ticket FLINK-27759 to follow the potential improvement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org