You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <br...@apache.org> on 2013/03/26 21:23:00 UTC
Re: svn commit: r1461237 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java
Hi Gary,
2013/3/26 <gg...@apache.org>
> Author: ggregory
> Date: Tue Mar 26 17:42:55 2013
> New Revision: 1461237
>
> URL: http://svn.apache.org/r1461237
> Log:
> Make internal API package private.
>
> Modified:
>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java
>
> Modified:
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java?rev=1461237&r1=1461236&r2=1461237&view=diff
>
> ==============================================================================
> ---
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java
> (original)
> +++
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java
> Tue Mar 26 17:42:55 2013
> @@ -33,7 +33,7 @@ import java.io.IOException;
> final class CSVLexer extends Lexer {
>
> /** INTERNAL API. ctor needs to be public so can be called
> dynamically by PerformanceTest class */
> - public CSVLexer(final CSVFormat format, final ExtendedBufferedReader
> in) {
> + CSVLexer(final CSVFormat format, final ExtendedBufferedReader in) {
> super(format, in);
> }
>
Does the PerformanceTest still work? This change seems to be contrary to
the comment above.
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: svn commit: r1461237 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java
Posted by Gary Gregory <ga...@gmail.com>.
On Tue, Mar 26, 2013 at 4:23 PM, Benedikt Ritter <br...@apache.org> wrote:
> Hi Gary,
>
>
> 2013/3/26 <gg...@apache.org>
>
> > Author: ggregory
> > Date: Tue Mar 26 17:42:55 2013
> > New Revision: 1461237
> >
> > URL: http://svn.apache.org/r1461237
> > Log:
> > Make internal API package private.
> >
> > Modified:
> >
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java
> >
> > Modified:
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java
> > URL:
> >
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java?rev=1461237&r1=1461236&r2=1461237&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java
> > (original)
> > +++
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java
> > Tue Mar 26 17:42:55 2013
> > @@ -33,7 +33,7 @@ import java.io.IOException;
> > final class CSVLexer extends Lexer {
> >
> > /** INTERNAL API. ctor needs to be public so can be called
> > dynamically by PerformanceTest class */
> > - public CSVLexer(final CSVFormat format, final ExtendedBufferedReader
> > in) {
> > + CSVLexer(final CSVFormat format, final ExtendedBufferedReader in) {
> > super(format, in);
> > }
> >
>
> Does the PerformanceTest still work? This change seems to be contrary to
> the comment above.
>
I'll adjust the comment.
Gary
>
>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory