[GitHub] [spark] wangyum commented on a change in pull request #35811: [SPARK-38516][BUILD] Add log4j-core, log4j-api and log4j-slf4j-impl to classpath if active hadoop-provided

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #35811:
URL: https://github.com/apache/spark/pull/35811#discussion_r824548662



##########
File path: pom.xml
##########
@@ -744,13 +744,11 @@
         <groupId>org.apache.logging.log4j</groupId>
         <artifactId>log4j-api</artifactId>
         <version>${log4j.version}</version>
-        <scope>${hadoop.deps.scope}</scope>
       </dependency>
       <dependency>
         <groupId>org.apache.logging.log4j</groupId>
         <artifactId>log4j-core</artifactId>
         <version>${log4j.version}</version>
-        <scope>${hadoop.deps.scope}</scope>
       </dependency>
       <dependency>
         <!-- API bridge between log4j 1 and 2 -->

Review comment:
       Thank you @eejbyfeldt . Removed it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org