You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Steve Bakke <st...@amd.com> on 2007/04/25 13:51:32 UTC

Committing deletion does not clear repository locks

We have a situation recently where the following sequence occurred:

% svn lock dir/file_with_needs_lock
% svn rm dir
% svn ci dir

Now lets say that we create a new directory of the same name and attempt to
add it:
% mkdir dir
% touch dir/file_with_needs_lock
% svn add dir
% svn status ­u
A         0   dir
A   O     0   dir/file_with_needs_lock

Sure enough, when you run 'svnlook lock <old-repo-path>', it shows the lock
that was acquired way back before the committed deletion.  We found that we
had to use svnadmin to unlock that path in order to clear out the
repository.

This seems like a bug to me.  Why doesn't subversion automatically clear a
lock for a file that has a successfully committed deletion?

-Steve



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org


Re: Committing deletion does not clear repository locks

Posted by Steve Bakke <st...@amd.com>.
One more thing that I don't know whether it matters.  The situation actually
involved two levels of directory:

% svn lock dir/dir2/file
% svn rm dir
% svn ci dir
...

It doesn't seem to me like that should matter what the directory depth is.
It also seems to be related to this bug:

http://subversion.tigris.org/issues/show_bug.cgi?id=2763

That one involves the fact that the parent directory of a commmitted
deletion still thinks that it has the deleted directory as part of its
working copy.

-steve

On 4/25/07 1:30 PM, "Steve Bakke" <st...@amd.com> wrote:

> 
> 
> On 4/25/07 10:08 AM, "Mark Phippard" <ma...@gmail.com> wrote:
> 
>> On 4/25/07, Steve Bakke <st...@amd.com> wrote:
>>> We have a situation recently where the following sequence occurred:
>>> 
>>> % svn lock dir/file_with_needs_lock
>>> % svn rm dir
>>> % svn ci dir
>>> 
>>> Now lets say that we create a new directory of the same name and attempt to
>>> add it:
>>> % mkdir dir
>>> % touch dir/file_with_needs_lock
>>> % svn add dir
>>> % svn status ­u
>>> A         0   dir
>>> A   O     0   dir/file_with_needs_lock
>>> 
>>> Sure enough, when you run 'svnlook lock <old-repo-path>', it shows the lock
>>> that was acquired way back before the committed deletion.  We found that we
>>> had to use svnadmin to unlock that path in order to clear out the
>>> repository.
>>> 
>>> This seems like a bug to me.  Why doesn't subversion automatically clear a
>>> lock for a file that has a successfully committed deletion?
>> 
>> I am not able to recreate this using either 1.4.3 or trunk.
>> 
>> I am using file:// protocol.  Perhaps the server protocol matters?
> 
> We were using svn+ssh with svnserve 1.4.0 and svn (client) 1.4.2
> 
> -steve
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: users-help@subversion.tigris.org
> 
> 
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org


Re: Committing deletion does not clear repository locks

Posted by Steve Bakke <st...@amd.com>.

On 4/25/07 10:08 AM, "Mark Phippard" <ma...@gmail.com> wrote:

> On 4/25/07, Steve Bakke <st...@amd.com> wrote:
>> We have a situation recently where the following sequence occurred:
>> 
>> % svn lock dir/file_with_needs_lock
>> % svn rm dir
>> % svn ci dir
>> 
>> Now lets say that we create a new directory of the same name and attempt to
>> add it:
>> % mkdir dir
>> % touch dir/file_with_needs_lock
>> % svn add dir
>> % svn status ­u
>> A         0   dir
>> A   O     0   dir/file_with_needs_lock
>> 
>> Sure enough, when you run 'svnlook lock <old-repo-path>', it shows the lock
>> that was acquired way back before the committed deletion.  We found that we
>> had to use svnadmin to unlock that path in order to clear out the
>> repository.
>> 
>> This seems like a bug to me.  Why doesn't subversion automatically clear a
>> lock for a file that has a successfully committed deletion?
> 
> I am not able to recreate this using either 1.4.3 or trunk.
> 
> I am using file:// protocol.  Perhaps the server protocol matters?

We were using svn+ssh with svnserve 1.4.0 and svn (client) 1.4.2

-steve



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org


Re: Committing deletion does not clear repository locks

Posted by Mark Phippard <ma...@gmail.com>.
On 4/25/07, Steve Bakke <st...@amd.com> wrote:
> We have a situation recently where the following sequence occurred:
>
> % svn lock dir/file_with_needs_lock
> % svn rm dir
> % svn ci dir
>
> Now lets say that we create a new directory of the same name and attempt to
> add it:
> % mkdir dir
> % touch dir/file_with_needs_lock
> % svn add dir
> % svn status ­u
> A         0   dir
> A   O     0   dir/file_with_needs_lock
>
> Sure enough, when you run 'svnlook lock <old-repo-path>', it shows the lock
> that was acquired way back before the committed deletion.  We found that we
> had to use svnadmin to unlock that path in order to clear out the
> repository.
>
> This seems like a bug to me.  Why doesn't subversion automatically clear a
> lock for a file that has a successfully committed deletion?

I am not able to recreate this using either 1.4.3 or trunk.

I am using file:// protocol.  Perhaps the server protocol matters?

-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org