You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by "Sven Rautenberg (JIRA)" <ji...@apache.org> on 2012/10/20 10:08:12 UTC
[jira] [Comment Edited] (LOG4PHP-121) Log4PHP classes should have
namespace/package prefix
[ https://issues.apache.org/jira/browse/LOG4PHP-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480672#comment-13480672 ]
Sven Rautenberg edited comment on LOG4PHP-121 at 10/20/12 8:07 AM:
-------------------------------------------------------------------
I'd be happy to support any effort, but I think the first step should be to define when to stop. There is a codesniffer standard representing all of PSR-0, PSR-1 and PSR-2 at https://github.com/klaussilveira/phpcs-psr .
And reformatting should be the first step before doing anything big in parallel, or the merge conflicts will be a pain.
was (Author: svenrtbg):
I'd be happy to support any effort, but I think the first step should be to define when to stop. Is there a codesniffer standard representing PSR-1 and -2 already? If we have something like this, there is no question of whether the code is yet to be reformatted.
And reformatting should be the first step before doing anything big in parallel, or the merge conflicts will be a pain.
> Log4PHP classes should have namespace/package prefix
> ----------------------------------------------------
>
> Key: LOG4PHP-121
> URL: https://issues.apache.org/jira/browse/LOG4PHP-121
> Project: Log4php
> Issue Type: Improvement
> Components: Code
> Environment: All
> Reporter: Sean W. Quinn
>
> Looking through the Log4PHP classes it is quickly apparent that there is no prefix to the class names. The Log4PHP library should make use of PEAR style namespacing prefix (e.g. Apache_Log4PHP_) or, less likely PHP's added support for native namespaces (e.g. Apache\Log4PHP). Obviously the PEAR style namespace prefixing is more desirable as it does not restrict usage of Log4PHP to systems running PHP 5.3+.
> This would be an immense improvement, allowing already established code bases to tie Log4PHP into their own auto-loading framework and avoid potential class name conflicts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira