[GitHub] [druid] jihoonson commented on a change in pull request #11081: Nested GroupBy query got wrong/empty result when using virtual column and filter

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #11081:
URL: https://github.com/apache/druid/pull/11081#discussion_r610961151



##########
File path: processing/src/test/java/org/apache/druid/query/groupby/NestedQueryPushDownTest.java
##########
@@ -584,6 +590,70 @@ public void testDimensionFilterOnOuterQuery()
     Assert.assertEquals(expectedRow0, results.get(0));
   }
 
+  @Test
+  public void testVirtualColumnFilterOnInnerQuery()

Review comment:
       This class is supposed to test groupBy queries with `GroupByQueryConfig.CTX_KEY_FORCE_PUSH_DOWN_NESTED_QUERY` enabled. Could you please move this test to somewhere else such as `GroupByQueryRunnerTest`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org