You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/09 07:04:35 UTC
[GitHub] [airflow] Fokko commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator
Fokko commented on a change in pull request #8256:
URL: https://github.com/apache/airflow/pull/8256#discussion_r422461754
##########
File path: tests/operators/test_python_operator.py
##########
@@ -340,6 +341,87 @@ def test_echo_env_variables(self):
t.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE)
+class TestPythonVirtualenvOperator(TestPythonBase):
+ @classmethod
+ def setUpClass(cls):
+ super(TestPythonVirtualenvOperator, cls).setUpClass()
+
+ session = Session()
+
+ session.query(DagRun).delete()
+ session.query(TI).delete()
+ session.commit()
+ session.close()
+
+ def setUp(self):
+ super(TestPythonVirtualenvOperator, self).setUp()
+
+ def del_env(key):
+ try:
+ del os.environ[key]
+ except KeyError:
+ pass
+
+ del_env('AIRFLOW_CTX_DAG_ID')
+ del_env('AIRFLOW_CTX_TASK_ID')
+ del_env('AIRFLOW_CTX_EXECUTION_DATE')
+ del_env('AIRFLOW_CTX_DAG_RUN_ID')
+ self.dag = DAG(
+ 'test_dag',
+ default_args={
+ 'owner': 'airflow',
+ 'start_date': DEFAULT_DATE})
+ self.addCleanup(self.dag.clear)
+ self.clear_run()
+ self.addCleanup(self.clear_run)
+
+ def tearDown(self):
+ super(TestPythonVirtualenvOperator, self).tearDown()
+
+ session = Session()
Review comment:
```python
with create_session() as session:
session.query(DagRun).delete()
session.query(TI).delete()
```
##########
File path: tests/operators/test_python_operator.py
##########
@@ -340,6 +341,87 @@ def test_echo_env_variables(self):
t.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE)
+class TestPythonVirtualenvOperator(TestPythonBase):
+ @classmethod
+ def setUpClass(cls):
+ super(TestPythonVirtualenvOperator, cls).setUpClass()
+
+ session = Session()
+
+ session.query(DagRun).delete()
+ session.query(TI).delete()
+ session.commit()
+ session.close()
+
+ def setUp(self):
+ super(TestPythonVirtualenvOperator, self).setUp()
+
+ def del_env(key):
+ try:
+ del os.environ[key]
+ except KeyError:
+ pass
+
+ del_env('AIRFLOW_CTX_DAG_ID')
+ del_env('AIRFLOW_CTX_TASK_ID')
+ del_env('AIRFLOW_CTX_EXECUTION_DATE')
+ del_env('AIRFLOW_CTX_DAG_RUN_ID')
+ self.dag = DAG(
+ 'test_dag',
+ default_args={
+ 'owner': 'airflow',
+ 'start_date': DEFAULT_DATE})
+ self.addCleanup(self.dag.clear)
+ self.clear_run()
+ self.addCleanup(self.clear_run)
+
+ def tearDown(self):
+ super(TestPythonVirtualenvOperator, self).tearDown()
+
+ session = Session()
+
+ session.query(DagRun).delete()
+ session.query(TI).delete()
+ print(len(session.query(DagRun).all()))
Review comment:
Can you remove the print?
##########
File path: tests/operators/test_python_operator.py
##########
@@ -340,6 +341,87 @@ def test_echo_env_variables(self):
t.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE)
+class TestPythonVirtualenvOperator(TestPythonBase):
+ @classmethod
+ def setUpClass(cls):
+ super(TestPythonVirtualenvOperator, cls).setUpClass()
+
+ session = Session()
Review comment:
```python
with create_session() as session:
session.query(DagRun).delete()
session.query(TI).delete()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org