You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/09/28 13:44:08 UTC

[GitHub] carbondata pull request #2789: [HOTFIX] Fixed S3 metrics issue.

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2789

    [HOTFIX] Fixed S3 metrics issue.

    Problem: When data read from s3 it shows the data read as more than the size of carbon data total size.
    Reason: It happens because carbondata uses `dataInputStream.skip` but in s3 interface it cannot handle properly it reads in a loop and reads more data than required.
    Solution: Use `FSDataInputStream.seek` instead of skip to fix this issue.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata s3-metrics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2789.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2789
    
----
commit 59eded7ecdc1d0e0536dbd0e1f77373c9866bf83
Author: ravipesala <ra...@...>
Date:   2018-09-28T12:59:08Z

    Fixed S3 metrics cache.

----


---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    LGTM


---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/833/



---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8902/



---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8943/



---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/875/



---

[GitHub] carbondata pull request #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2789


---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/645/



---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/681/



---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    retest this please


---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    LGTM


---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8908/



---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/637/



---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2789
  
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/840/



---