You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/01/17 18:55:58 UTC

[GitHub] spark pull request #16611: [WIP][SPARK-17967][SPARK-17878][SQL][PYTHON] Supp...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16611#discussion_r96482934
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextHadoopFsRelationSuite.scala ---
    @@ -69,18 +69,19 @@ class SimpleTextHadoopFsRelationSuite extends HadoopFsRelationTest with Predicat
       test("test hadoop conf option propagation") {
         withTempPath { file =>
           // Test write side
    +      val nullVal: String = null
    --- End diff --
    
    Do you think this is okay BTW @rxin ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org