You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/10/27 21:44:53 UTC

[PR] GH-38498: [Python][Compute] `random` does not respect options arg [arrow]

Fokko opened a new pull request, #38499:
URL: https://github.com/apache/arrow/pull/38499

   <!--
   Thanks for opening a pull request!
   If this is your first pull request you can find detailed information on how 
   to contribute here:
     * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
   
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   -->
   
   ### Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   ### What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ### Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ### Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
   -->
   <!-- **This PR includes breaking changes to public APIs.** -->
   
   <!--
   Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
   -->
   <!-- **This PR contains a "Critical Fix".** -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-38498: [Python][Compute] `random` does not respect options arg [arrow]

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #38499:
URL: https://github.com/apache/arrow/pull/38499#issuecomment-2273343432

   @Fokko another gentle ping :) 
   Otherwise I am also happy to take over the PR if you prefer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-38498: [Python][Compute] `random` does not respect options arg [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #38499:
URL: https://github.com/apache/arrow/pull/38499#issuecomment-1830376659

   > Thank you for your contribution! The change looks good. Could you please fix the CI errors?
   
   Ping @Fokko .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-38498: [Python][Compute] `random` does not respect options arg [arrow]

Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #38499:
URL: https://github.com/apache/arrow/pull/38499#issuecomment-1801020599

   Thank you for your contribution! The change looks good. Could you please fix the CI errors?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-38498: [Python][Compute] `random` does not respect options arg [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #38499:
URL: https://github.com/apache/arrow/pull/38499#issuecomment-1930446400

   @Fokko Are you still interested in working on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-38498: [Python][Compute] `random` does not respect options arg [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38499:
URL: https://github.com/apache/arrow/pull/38499#issuecomment-1783545345

   :warning: GitHub issue #38498 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-38498: [Python][Compute] `random` does not respect options arg [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #38499:
URL: https://github.com/apache/arrow/pull/38499#discussion_r1446463609


##########
python/pyarrow/compute.py:
##########
@@ -661,7 +661,7 @@ def random(n, *, initializer='system', options=None, memory_pool=None):
     memory_pool : pyarrow.MemoryPool, optional
         If not passed, will allocate memory from the default memory pool.
     """
-    options = RandomOptions(initializer=initializer)
+    options = options or RandomOptions(initializer=initializer)

Review Comment:
   We should ideally raise an error if passing both `options` and `initializer`, can you add that and a test for it?
   Similar example:
   ```python
   >>> pc.sum([1,2,None], skip_nulls=False)
   <pyarrow.Int64Scalar: None>
   >>> pc.sum([1,2,None], options=pc.ScalarAggregateOptions(skip_nulls=False))
   <pyarrow.Int64Scalar: None>
   >>> pc.sum([1,2,None], skip_nulls=False, options=pc.ScalarAggregateOptions(skip_nulls=False))
   Traceback (most recent call last):
     Cell In[8], line 1
       pc.sum([1,2,None], skip_nulls=False, options=pc.ScalarAggregateOptions(skip_nulls=False))
     File ~/arrow/dev/python/pyarrow/compute.py:259 in wrapper
       options = _handle_options(func_name, options_class, options,
     File ~/arrow/dev/python/pyarrow/compute.py:218 in _handle_options
       raise TypeError(
   TypeError: Function 'sum' called with both an 'options' argument and additional arguments
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-38498: [Python][Compute] `random` does not respect options arg [arrow]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #38499:
URL: https://github.com/apache/arrow/pull/38499#issuecomment-2273653571

   @jorisvandenbossche Feel free to take this one, I'm a bit swamped :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-38498: [Python][Compute] `random` does not respect options arg [arrow]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed pull request #38499: GH-38498: [Python][Compute] `random` does not respect options arg
URL: https://github.com/apache/arrow/pull/38499


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org