[GitHub] [pulsar] merlimat commented on a change in pull request #4079: PIP-34 Key_Shared subscription core implementation.

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #4079: PIP-34 Key_Shared subscription core implementation.
URL: https://github.com/apache/pulsar/pull/4079#discussion_r277902577
 
 

 ##########
 File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/TypedMessageBuilder.java
 ##########
 @@ -103,6 +103,15 @@
      */
     TypedMessageBuilder<T> keyBytes(byte[] key);
 
+    /**
+     * Sets the ordering key of the message for message dispatch in {@link SubscriptionType#Key_Shared} mode.
+     * Partition key Will be used if ordering key not specified
+     *
+     * @param orderingKey the ordering key for the message
+     * @return the message builder instance
+     */
+    TypedMessageBuilder<T> orderingKey(byte[] orderingKey);
 
 Review comment:
   This is hugely confusing. Now we can have 2 different keys on the message. Users might think the other key doesn't guarantee ordering.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services