You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by BJangir <gi...@git.apache.org> on 2018/04/25 13:01:17 UTC
[GitHub] carbondata pull request #2227: [CARBONDATA-2401] Date and Timestamp options ...
GitHub user BJangir opened a pull request:
https://github.com/apache/carbondata/pull/2227
[CARBONDATA-2401] Date and Timestamp options are not working in SDK
Issue:- Date and Timestamp format is passed in options of SDK but data load is failed even correct data is set as per format .
Cause:- Load model is getting overwritten with default .
Fix :- if user has passed the options then Load model should use from Options otherwise from Default.
- [ ] Any interfaces changed?
NO
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
No
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
--UT is added
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2401
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2227
----
commit 5b33b6c44cb86de54af8c021a5b5fc5c6948d2a9
Author: BJangir <ba...@...>
Date: 2018-04-25T12:57:58Z
[CARBONDATA-2401] Date and Timestamp options are not working in SDK
----
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2227
retest this please
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by BJangir <gi...@git.apache.org>.
Github user BJangir commented on the issue:
https://github.com/apache/carbondata/pull/2227
retest this please
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2227
LGTM
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5535/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5541/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2227
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4832/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by BJangir <gi...@git.apache.org>.
Github user BJangir commented on the issue:
https://github.com/apache/carbondata/pull/2227
retest please
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4314/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5582/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5664/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5481/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4378/
---
[GitHub] carbondata pull request #2227: [CARBONDATA-2401] Date and Timestamp options ...
Posted by BJangir <gi...@git.apache.org>.
Github user BJangir commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2227#discussion_r187087122
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java ---
@@ -81,9 +81,8 @@ public CarbonLoadModel build(Map<String, String> options, long UUID, String task
build(options, optionsFinal, model, null);
- // set default values
- model.setTimestampformat(CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT);
- model.setDateFormat(CarbonCommonConstants.CARBON_DATE_DEFAULT_FORMAT);
+ // set default values other than time format
--- End diff --
OK.Fixed
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2227
retest this please
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2227
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4535/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4229/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4271/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4318/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5534/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5441/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by BJangir <gi...@git.apache.org>.
Github user BJangir commented on the issue:
https://github.com/apache/carbondata/pull/2227
retest this please
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by BJangir <gi...@git.apache.org>.
Github user BJangir commented on the issue:
https://github.com/apache/carbondata/pull/2227
Retest this please
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5396/
---
[GitHub] carbondata pull request #2227: [CARBONDATA-2401] Date and Timestamp options ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2227
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2227
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4586/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4504/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4372/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5589/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2227
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4677/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5484/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2227
retest this please
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4428/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4627/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4421/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4624/
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by BJangir <gi...@git.apache.org>.
Github user BJangir commented on the issue:
https://github.com/apache/carbondata/pull/2227
retest this please
---
[GitHub] carbondata pull request #2227: [CARBONDATA-2401] Date and Timestamp options ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2227#discussion_r186276999
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java ---
@@ -81,9 +81,8 @@ public CarbonLoadModel build(Map<String, String> options, long UUID, String task
build(options, optionsFinal, model, null);
- // set default values
- model.setTimestampformat(CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT);
- model.setDateFormat(CarbonCommonConstants.CARBON_DATE_DEFAULT_FORMAT);
+ // set default values other than time format
--- End diff --
This comment can be removed
---
[GitHub] carbondata issue #2227: [CARBONDATA-2401] Date and Timestamp options are not...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2227
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5780/
---