[jira] [Commented] (HBASE-17134) Command line tool: unification of argument names

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687875#comment-15687875 ] 

Hadoop QA commented on HBASE-17134:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s {color} | {color:red} HBASE-17134 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12840112/HBASE-17134-v1.patch |
| JIRA Issue | HBASE-17134 |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/4579/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Command line tool: unification of argument names
> ------------------------------------------------
>
>                 Key: HBASE-17134
>                 URL: https://issues.apache.org/jira/browse/HBASE-17134
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>         Attachments: HBASE-17134-v1.patch
>
>
> {quote}
> So, in backup usage, the backup root dir is called backup_root. In restore, it is called backup_path. I presume these are meant to refer to the same thing?
> In restore, the id for the backup is the backup_id but in describe when I am to pass a backup id, it is called backupId. Ditto on delete. In the dump of the history, the backup id is called 'ID'.
> Suggest you use same name for the arg everywhere. The inconsistency makes the tool appear untrustworthy.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)