You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Tim Armstrong (JIRA)" <ji...@apache.org> on 2011/08/19 19:30:27 UTC
[jira] [Created] (HIVE-2396) RCFileReader Buffer Reuse
RCFileReader Buffer Reuse
-------------------------
Key: HIVE-2396
URL: https://issues.apache.org/jira/browse/HIVE-2396
Project: Hive
Issue Type: Improvement
Components: Query Processor
Affects Versions: 0.8.0
Reporter: Tim Armstrong
Assignee: Tim Armstrong
Priority: Minor
Fix For: 0.8.0
Attachments: rcfile_bufreuse.java
Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087981#comment-13087981 ]
He Yongqiang commented on HIVE-2396:
------------------------------------
@Carl, can you verify that HIVE-2350 is committed to trunk or not, and if not, can u commit to trunk? Thanks!
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong updated HIVE-2396:
--------------------------------
Attachment: (was: rcfile_bufreuse_2011-08-19.patch)
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong updated HIVE-2396:
--------------------------------
Attachment: rcfile_bufreuse.java
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse.java
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong updated HIVE-2396:
--------------------------------
Status: Patch Available (was: Open)
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong updated HIVE-2396:
--------------------------------
Attachment: rcfile_bufreuse_2011-08-19.patch
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089814#comment-13089814 ]
Carl Steinbach commented on HIVE-2396:
--------------------------------------
+1. Will commit if tests pass.
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse-2011-08-23.patch, rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089598#comment-13089598 ]
Tim Armstrong commented on HIVE-2396:
-------------------------------------
Review board request is now online: https://reviews.apache.org/r/1628/
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse-2011-08-23.patch, rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2396:
---------------------------------
Status: Open (was: Patch Available)
@Tim: That patch doesn't apply cleanly. Can you please rebase it? Thanks.
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2396:
---------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Tim!
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse-2011-08-23.patch, rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong updated HIVE-2396:
--------------------------------
Attachment: rcfile_bufreuse_2011-08-19.patch
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong updated HIVE-2396:
--------------------------------
Attachment: rcfile_bufreuse-2011-08-23.patch
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse-2011-08-23.patch, rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087970#comment-13087970 ]
Tim Armstrong commented on HIVE-2396:
-------------------------------------
It depends on the changes in HIVE-2350, which haven't shown up in trunk yet, I'll wait until trunk is updated then submit a clean patch.
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087821#comment-13087821 ]
Tim Armstrong commented on HIVE-2396:
-------------------------------------
This passes the unit test suite.
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong updated HIVE-2396:
--------------------------------
Attachment: (was: rcfile_bufreuse.java)
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Tim Armstrong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong updated HIVE-2396:
--------------------------------
Status: Patch Available (was: Open)
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse-2011-08-23.patch, rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088971#comment-13088971 ]
Carl Steinbach commented on HIVE-2396:
--------------------------------------
@Yongqiang: HIVE-2350 was not committed. Closing that ticket was a mistake on my part. Yes, I'll commit it to trunk.
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2396) RCFileReader Buffer Reuse
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089555#comment-13089555 ]
Ning Zhang commented on HIVE-2396:
----------------------------------
Tim, could you create a review board request (reviews.apache.org) and upload the patch there (after necessary rebasing)? It would be much easier for review there.
> RCFileReader Buffer Reuse
> -------------------------
>
> Key: HIVE-2396
> URL: https://issues.apache.org/jira/browse/HIVE-2396
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: rcfile_bufreuse_2011-08-19.patch
>
>
> Minor tweak to RCFile$Reader which improves read performance by reusing value buffers. This reduces object allocation.
> Depends on HIVE-2350
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira