You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2016/02/04 20:22:26 UTC

Review Request 43206: Create patch upgrade orchestration based on available services

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43206/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-14924
    https://issues.apache.org/jira/browse/AMBARI-14924


Repository: ambari


Description
-------

Update the orchestration classes to schedule services only defined in the Version Definition file.

Also updated a pre-req check to allow an upgrade when a host's repo state is NOT_REQUIRED.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java 30250ef 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 70440fc 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java ee99a1e 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 4af4216 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java bd87a55 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8213a78 
  ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java 4529554 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java eb5bf62 

Diff: https://reviews.apache.org/r/43206/diff/


Testing
-------

Manual.  Automated pending.


Thanks,

Nate Cole


Re: Review Request 43206: Create patch upgrade orchestration based on available services

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43206/#review117873
-----------------------------------------------------------


Ship it!





ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java (line 282)
<https://reviews.apache.org/r/43206/#comment179128>

    Nice


- Alejandro Fernandez


On Feb. 4, 2016, 7:52 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43206/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 7:52 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-14924
>     https://issues.apache.org/jira/browse/AMBARI-14924
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update the orchestration classes to schedule services only defined in the Version Definition file.
> 
> Also updated a pre-req check to allow an upgrade when a host's repo state is NOT_REQUIRED.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java 30250ef 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 70440fc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java ee99a1e 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 4af4216 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java bd87a55 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8213a78 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java 4529554 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java eb5bf62 
> 
> Diff: https://reviews.apache.org/r/43206/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> Tests run: 3801, Failures: 0, Errors: 0, Skipped: 31
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:52.634s
> [INFO] Finished at: Thu Feb 04 14:49:43 EST 2016
> [INFO] Final Memory: 33M/713M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 43206: Create patch upgrade orchestration based on available services

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43206/#review118000
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 4, 2016, 9:52 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43206/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 9:52 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-14924
>     https://issues.apache.org/jira/browse/AMBARI-14924
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update the orchestration classes to schedule services only defined in the Version Definition file.
> 
> Also updated a pre-req check to allow an upgrade when a host's repo state is NOT_REQUIRED.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java 30250ef 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 70440fc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java ee99a1e 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 4af4216 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java bd87a55 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8213a78 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java 4529554 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java eb5bf62 
> 
> Diff: https://reviews.apache.org/r/43206/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> Tests run: 3801, Failures: 0, Errors: 0, Skipped: 31
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:52.634s
> [INFO] Finished at: Thu Feb 04 14:49:43 EST 2016
> [INFO] Final Memory: 33M/713M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 43206: Create patch upgrade orchestration based on available services

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43206/
-----------------------------------------------------------

(Updated Feb. 4, 2016, 2:52 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-14924
    https://issues.apache.org/jira/browse/AMBARI-14924


Repository: ambari


Description
-------

Update the orchestration classes to schedule services only defined in the Version Definition file.

Also updated a pre-req check to allow an upgrade when a host's repo state is NOT_REQUIRED.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java 30250ef 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 70440fc 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java ee99a1e 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 4af4216 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java bd87a55 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8213a78 
  ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java 4529554 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java eb5bf62 

Diff: https://reviews.apache.org/r/43206/diff/


Testing (updated)
-------

Manual.  Automated:

Tests run: 3801, Failures: 0, Errors: 0, Skipped: 31

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:52.634s
[INFO] Finished at: Thu Feb 04 14:49:43 EST 2016
[INFO] Final Memory: 33M/713M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole