[GitHub] [airflow] oliverisaac commented on pull request #18336: Configuration lookup in environment wil ignore empty env var

[GitBox <gi...@apache.org>]

oliverisaac commented on pull request #18336:
URL: https://github.com/apache/airflow/pull/18336#issuecomment-922118076


   The root of the problem is that the helm chart does not work if you do not use the built in database connection config: the chart always defines the environment var `AIRFLOW__CORE__SQL_ALCHEMY_CONN` and thus one cannot override that environment var with any other config as the configuration precedence dictates that `AIRFLOW__CORE__SQL_ALCHEMY_CONN` is higher precedence tahn `AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD` or `AIRFLOW__CORE__SQL_ALCHEMY_CONN_SECRET` (let alone the config files.)
   
   As I was looking to solve that problem, the behavior of blindly using an empty string from an env var seemed like the wrong default to set. Especially when empty strings are not a valid configuration for `AIRFLOW__CORE__SQL_ALCHEMY_CONN`. 
   
   Another approach could be saving the first env var that is set and, if none of the others are set, then we return the first one we found. Otherwise, we return the first non-empty env var.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org