You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/27 14:38:43 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1377: MINIFICPP-1865 Integrate performance clang-tidy checks in CI

adamdebreceni commented on code in PR #1377:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1377#discussion_r931147917


##########
extensions/http-curl/tests/unit/InvokeHTTPTests.cpp:
##########
@@ -238,14 +238,14 @@ TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
   auto records = plan->getProvenanceRecords();
   std::shared_ptr<core::FlowFile> record = plan->getCurrentFlowFile();
   REQUIRE(record == nullptr);
-  REQUIRE(records.size() == 0);
+  REQUIRE(records.empty());

Review Comment:
   I feel like these transformations in `REQUIRE` are not advantageous, as in the former case we get an error like "error: 3 != 0", while in this new case we get "<...> is false"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org