You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/12/30 15:14:04 UTC
[GitHub] [logging-log4j2] Francis-FY opened a new pull request #676: LOG4J2-3304 - Fix issue that the initialize status of LogManager is not set when factoryClassName is present and instantiate successfully
Francis-FY opened a new pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676
Fix the issue that the initialize status of LogManager is not set when logger factoryClassName is present and instantiate successfully, see [LOG4J2-3304](https://issues.apache.org/jira/browse/LOG4J2-3304)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] Francis-FY commented on pull request #676: LOG4J2-3304 - Fix issue that the initialize status of LogManager is not set when factoryClassName is present and instantiate successfully
Posted by GitBox <gi...@apache.org>.
Francis-FY commented on pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676#issuecomment-1003100483
@rgoers The method getEvnironment of SpringEnvironmentHolder will check if LogManager is initialized through LogManagerStatus.isInitialized(). You can run a unit test to validate.
1. create file log4j2.component.properties containing `log4j2.loggerContextFactory=org.apache.logging.log4j.core.impl.Log4jContextFactory`
2. run test `org.apache.logging.log4j.spring.boot.SpringLookupTest` or `org.apache.logging.log4j.spring.boot.SpringProfileTest`
3. the test will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory edited a comment on pull request #676: LOG4J2-3304 - Fix issue that the initialize status of LogManager is not set when factoryClassName is present and instantiate successfully
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676#issuecomment-1003084416
Hi @Francis-FY
Thank you for your PR.
How could this be validated in a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers merged pull request #676: LOG4J2-3304 - Fix issue that the initialize status of LogManager is not set when factoryClassName is present and instantiate successfully
Posted by GitBox <gi...@apache.org>.
rgoers merged pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #676: LOG4J2-3304 - Fix issue that the initialize status of LogManager is not set when factoryClassName is present and instantiate successfully
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676#issuecomment-1003093157
I'm having a hard time understanding how this relates to Log4j's Spring Boot support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #676: LOG4J2-3304 - Fix issue that the initialize status of LogManager is not set when factoryClassName is present and instantiate successfully
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676#issuecomment-1003084416
Hi @Francis-FY
Thank you for your PR?
How could this be validated in a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org