You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2014/03/18 14:01:50 UTC
[jira] [Resolved] (WICKET-5284) Too deep recursion in
AbstractHierarchyIterator
[ https://issues.apache.org/jira/browse/WICKET-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-5284.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.15.0
7.0.0
Component hierarchy iterators have been marked deprecated and will be removed in Wicket 8.0.
Applications are recommended to use IVisitor based methods.
> Too deep recursion in AbstractHierarchyIterator
> -----------------------------------------------
>
> Key: WICKET-5284
> URL: https://issues.apache.org/jira/browse/WICKET-5284
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.9.1
> Reporter: Martin Petricek
> Assignee: Martin Grigorov
> Fix For: 7.0.0, 6.15.0
>
>
> In application we have code as follows:
> MarkupContainer mc = ...;
> ComponentHierarchyIterator iter = mc.visitChildren(FormComponent.class);
> for (Component c : iter) {
> ...
> }
> However, when run, on many pages this causes java.lang.StackOverflowError, with lots of the stacktrace filled with lines like this:
> ...
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:297)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:297)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
> ...
> It seems that the search for next component in the iteration produces too deep recursion here (not infinite, but too deep for processing a typical page with relatively lots of components) and I suspect that the length of the stack used by the iterator is proportional to the total number of components in the page.
--
This message was sent by Atlassian JIRA
(v6.2#6252)