[GitHub] [incubator-superset] lilykuang commented on a change in pull request #9982: feat: implement secondary navigation for datasets

[GitBox <gi...@apache.org>]

lilykuang commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r436859858



##########
File path: superset-frontend/src/components/Menu/Menu.less
##########
@@ -39,3 +43,42 @@
     }
   }
 }
+
+#secondary-menu {
+  margin-top: -20px;
+  .navbar-header .navbar-brand {
+    font-weight: @font-weight-bold;
+  }
+  .navbar-right {
+    .btn-default {
+      text-transform: uppercase;
+      font-weight: 500;
+      font-size: @font-size-s;
+      background-color: @brand-primary;
+      border-radius: 4px;
+      color: @lightest;
+      margin: 8px 43px;
+      padding: 8px 51px 8px 43px;
+      border: none;
+      i {
+        padding: 4px @font-size-xs;
+      }
+    }
+  }
+  .navbar-nav {
+    li {
+      a {
+        font-size: @font-size-s;
+        padding: 8px;
+        margin: 8px;
+        color: @gray-drak-heading;
+      }
+    }
+    li.active > a,
+    li > a:hover {
+      background-color: @gray-light-hover;
+      border-bottom: none;
+      border-radius: 4px;
+    }
+  }
+}

Review comment:
       @ktmud good suggestion. I think moving to these to styled components will be cleaner. I  will move css to the component. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org