You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/31 23:53:23 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #9064: [SQL
Lab] Improve autocomplete performance
etr2460 opened a new pull request #9064: [SQL Lab] Improve autocomplete performance
URL: https://github.com/apache/incubator-superset/pull/9064
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Our instance of superset has large numbers of schemas and tables, so the sql lab autocomplete corpus can be around 40k elements long. Performing the object spread operator was taking up about 50% of the execution time, and removing was able to improve performance from 100ms per keystroke to 40ms.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TEST PLAN
Test autocomplete for all types of words, ensure it still works
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @graceguo-supercat @betodealmeida @michellethomas @john-bodley
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #9064: [SQL Lab]
Improve autocomplete performance
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9064: [SQL Lab] Improve autocomplete performance
URL: https://github.com/apache/incubator-superset/pull/9064
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9064: [SQL Lab]
Improve autocomplete performance
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9064: [SQL Lab] Improve autocomplete performance
URL: https://github.com/apache/incubator-superset/pull/9064#issuecomment-580974919
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9064?src=pr&el=h1) Report
> Merging [#9064](https://codecov.io/gh/apache/incubator-superset/pull/9064?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2629c779af10b18d669d9af8612b92b7138bdd38?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9064?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9064 +/- ##
==========================================
- Coverage 59.45% 59.44% -0.02%
==========================================
Files 369 369
Lines 11747 11749 +2
Branches 2888 2888
==========================================
Hits 6984 6984
- Misses 4584 4586 +2
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9064?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../assets/src/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9064/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9BY2VFZGl0b3JXcmFwcGVyLmpzeA==) | `52.94% <0%> (-1.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9064?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9064?src=pr&el=footer). Last update [2629c77...925e75b](https://codecov.io/gh/apache/incubator-superset/pull/9064?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org