[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5239: Externalize KVM Agent storage's timeout configuration

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #5239:
URL: https://github.com/apache/cloudstack/pull/5239#discussion_r677155975



##########
File path: agent/conf/agent.properties
##########
@@ -266,3 +266,7 @@ iscsi.session.cleanup.enabled=false
 # Automatically clean up iscsi sessions not attached to any VM.
 # Should be enabled for users using managed storage for example solidfire.
 # Should be disabled for users with unmanaged iscsi connections on their hosts
+
+# This parameter specifies the heartbeat update timeout in ms; The default value is 60000ms (1 min).
+# Depending on the use case, this timeout might need increasing/decreasing.
+# heartbeat.update.timeout=60000

Review comment:
       @GutoVeronezi 
   please add a "\n" to the end of the file.
   it caused failures in trillian test that fresh installed host cannot be added to zone.
   
   in /etc/cloudstack/agent/agent.properties,
   ```
   # heartbeat.update.timeout=60000keystore.passphrase=RFXZya8a4esacWaG
   ```
   should be
   ```
   # heartbeat.update.timeout=60000
   keystore.passphrase=RFXZya8a4esacWaG
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org