You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Kim van der Riet (JIRA)" <ji...@apache.org> on 2014/11/25 21:45:12 UTC
[jira] [Resolved] (QPID-6248) [linearstore] Symlink creation fails
if store dir path is not absolute
[ https://issues.apache.org/jira/browse/QPID-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kim van der Riet resolved QPID-6248.
------------------------------------
Resolution: Fixed
The store-dir parameter should never be a relative path, but this has been benign for some time in both linearstore and legacystore. However, with the change to using symlinks in the journal directories, it has now created an error condition.
Using the assumption that if a relative path is used for store-dir, it would be relative to the current working directory, this value is now prefixed to the store-dir parameter if it does not start with character '/'.
> [linearstore] Symlink creation fails if store dir path is not absolute
> ----------------------------------------------------------------------
>
> Key: QPID-6248
> URL: https://issues.apache.org/jira/browse/QPID-6248
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Reporter: Kim van der Riet
> Assignee: Kim van der Riet
>
> Thanks to Alan Conway for finding this bug:
> {quote}
> I uncovered a bug in the way symlinks are created if the data directory
> is not an absolute path. It appears that the code creating the symlink
> assumes that the path is absolute, which gives invalid symlinks. For
> example in the following the brokers working directory
> is /home/aconway/qpid/debug/src/tests/interop_tests.tmp/interop_tests.PythonTxTest.test_tx_simple_rollback
> and the data dir is "broker2"
> {noformat}
> 2014-11-18 11:26:33.216699232 [Store] debug Linear Store: Journal
> "TplStore":Journal directory = "broker2/qls/tpl/"
> ls -l /home/aconway/qpid/debug/src/tests/interop_tests.tmp/interop_tests.PythonTxTest.test_tx_simple_rollback/broker2/qls/jrnl/interop_tests.PythonTxTest.test_tx_simple_rollback-a
> total 4
> lrwxrwxrwx. 1 aconway aconway 71 Nov 18 11:18 3ee76ade-3793-4056-ac39-98f566cb345e.jrnl -> broker2/qls/p001/2048k/in_use/3ee76ade-3793-4056-ac39-98f566cb345e.jrnl
> [aconway@wallace dispatch (trunk)]$
> {noformat}
> I think you should be resolving the path to an absolute path (relative to current working dir) before creating the symlink.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org