You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/27 03:20:56 UTC
[GitHub] [shardingsphere] MingxingLAI opened a new issue #10202: Reduce code complexity and improve readability for ShardingUnicastRoutingEngine
MingxingLAI opened a new issue #10202:
URL: https://github.com/apache/shardingsphere/issues/10202
When I read the source code of this project, The code readability of this [file](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/unicast/ShardingUnicastRoutingEngine.java) is significantly lower than other files.
Optimization suggestion：
- Reduce the length of the route function
- Reduce code nesting depth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero closed issue #10202: Reduce code complexity and improve readability for ShardingUnicastRoutingEngine
Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #10202:
URL: https://github.com/apache/shardingsphere/issues/10202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #10202: Reduce code complexity and improve readability for ShardingUnicastRoutingEngine
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #10202:
URL: https://github.com/apache/shardingsphere/issues/10202#issuecomment-827306512
Good idea 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org