You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/07/30 08:19:45 UTC

[GitHub] activemq-artemis pull request #2198: ARTEMIS-856 - Support consumersBeforeDi...

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2198

    ARTEMIS-856 - Support consumersBeforeDispatch and delayBeforeDispatch

    https://issues.apache.org/jira/browse/ARTEMIS-856
    
    This is equivalent to consumersBeforeDispatchStarts and timeBeforeDispatchStarts in ActiveMQ 5.x
    
    http://activemq.apache.org/message-groups.html
    
    This is addressing one of the items on the artemis roadmap: http://activemq.apache.org/activemq-artemis-roadmap.html

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-856

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2198
    
----
commit d01e2d2539ed67ce4f617363ac536b4d0a6d02da
Author: Michael André Pearce <mi...@...>
Date:   2018-07-06T06:44:15Z

    ARTEMIS-856 - Support consumersBeforeDispatch and delayBeforeDispatch
    
    https://issues.apache.org/jira/browse/ARTEMIS-856
    
    This is equivalent to consumersBeforeDispatchStarts and timeBeforeDispatchStarts in ActiveMQ 5.x
    
    http://activemq.apache.org/message-groups.html
    
    This is addressing one of the items on the artemis roadmap: http://activemq.apache.org/activemq-artemis-roadmap.html

----


---

[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2198
  
    @michaelandrepearce What did you do to fix the karaf verification? i lost some sleep the other trying to figure it out and I'm now curious.


---

[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2198
  
    @clebertsuconic i removed the custom AtomicBooleanFieldUpdater as @franz1981 wanted and just used AtomicIntegerFieldUpdater direct. Seems i fix the issue and make @franz1981 happy. 


---

[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2198
  
    @michaelandrepearce Ok.. there's an issue with packaging in Karaf for Util depending on how you use. I'm sure it will arise again.


---

[GitHub] activemq-artemis pull request #2198: ARTEMIS-856 - Support consumersBeforeDi...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2198


---

[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2198
  
    @clebertsuconic would let me re-open so heres new PR of the same branch. Ive deduced the failure in test case in is that it seems when the journal is reloaded the queues arent there, thus it doesnt reload messages, on debugging it seems to write to the journal as far as i can tell, but it seems something go wrong in that area.


---

[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2198
  
    @clebertsuconic re-pushed to kick off build again and all green. You ok to merge?


---

[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2198
  
    i think its the same issue @cshannon  is getting on his PR also. https://github.com/apache/activemq-artemis/pull/2191


---