You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/03/26 03:47:01 UTC
Review Request: SQOOP-912 Add ability to specify --hive-database parameter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10133/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've added new parameter --hive-database that can be used to specify database in hive.
This addresses bug SQOOP-912.
https://issues.apache.org/jira/browse/SQOOP-912
Diffs
-----
src/java/org/apache/sqoop/SqoopOptions.java 08bab1e
src/java/org/apache/sqoop/hive/TableDefWriter.java 3563c67
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9874bae
src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 6610b75
Diff: https://reviews.apache.org/r/10133/diff/
Testing
-------
New unit test added. Tests seems to be passing and I've run the patch on real hadoop cluster.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-912 Add ability to specify --hive-database
parameter
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10133/#review18381
-----------------------------------------------------------
Ship it!
Thanks for taking this up Jarcec. I was planning to take some of these after my current work is done but youbeat me to it.
Venkat
- Venkat Ranganathan
On March 26, 2013, 2:47 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10133/
> -----------------------------------------------------------
>
> (Updated March 26, 2013, 2:47 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've added new parameter --hive-database that can be used to specify database in hive.
>
>
> This addresses bug SQOOP-912.
> https://issues.apache.org/jira/browse/SQOOP-912
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/SqoopOptions.java 08bab1e
> src/java/org/apache/sqoop/hive/TableDefWriter.java 3563c67
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9874bae
> src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 6610b75
>
> Diff: https://reviews.apache.org/r/10133/diff/
>
>
> Testing
> -------
>
> New unit test added. Tests seems to be passing and I've run the patch on real hadoop cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request: SQOOP-912 Add ability to specify --hive-database
parameter
Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10133/#review19191
-----------------------------------------------------------
Ship it!
Ship It!
- Kathleen Ting
On March 26, 2013, 2:47 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10133/
> -----------------------------------------------------------
>
> (Updated March 26, 2013, 2:47 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've added new parameter --hive-database that can be used to specify database in hive.
>
>
> This addresses bug SQOOP-912.
> https://issues.apache.org/jira/browse/SQOOP-912
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/SqoopOptions.java 08bab1e
> src/java/org/apache/sqoop/hive/TableDefWriter.java 3563c67
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9874bae
> src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 6610b75
>
> Diff: https://reviews.apache.org/r/10133/diff/
>
>
> Testing
> -------
>
> New unit test added. Tests seems to be passing and I've run the patch on real hadoop cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>