You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/10/27 13:55:06 UTC
[GitHub] [incubator-doris] francisoliverlee opened a new pull request #4808: [optimize] optimize default value for thriftserver's config key "thrift_client_timeout_ms"
francisoliverlee opened a new pull request #4808:
URL: https://github.com/apache/incubator-doris/pull/4808
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui merged pull request #4808: [optimize] optimize default value for thriftserver's config key "thrift_client_timeout_ms"
Posted by GitBox <gi...@apache.org>.
caiconghui merged pull request #4808:
URL: https://github.com/apache/incubator-doris/pull/4808
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #4808: [optimize] optimize default value for thriftserver's config key "thrift_client_timeout_ms"
Posted by GitBox <gi...@apache.org>.
chaoyli commented on a change in pull request #4808:
URL: https://github.com/apache/incubator-doris/pull/4808#discussion_r513143370
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -318,8 +318,10 @@
* The connection timeout and socket timeout config for thrift server
* The value for thrift_client_timeout_ms is set to be larger than zero to prevent
* some hang up problems in java.net.SocketInputStream.socketRead0
+ *
+ * make it one hour to avoid fe close the socket so frequently, that be will retry to cost more time
*/
- @ConfField public static int thrift_client_timeout_ms = 30000;
Review comment:
when will fe close the socket frequently?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #4808: [optimize] optimize default value for thriftserver's config key "thrift_client_timeout_ms"
Posted by GitBox <gi...@apache.org>.
caiconghui commented on pull request #4808:
URL: https://github.com/apache/incubator-doris/pull/4808#issuecomment-718438752
@francisoliverlee Please provide an issue related to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] francisoliverlee commented on a change in pull request #4808: [optimize] optimize default value for thriftserver's config key "thrift_client_timeout_ms"
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on a change in pull request #4808:
URL: https://github.com/apache/incubator-doris/pull/4808#discussion_r513583661
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -318,8 +318,10 @@
* The connection timeout and socket timeout config for thrift server
* The value for thrift_client_timeout_ms is set to be larger than zero to prevent
* some hang up problems in java.net.SocketInputStream.socketRead0
+ *
+ * make it one hour to avoid fe close the socket so frequently, that be will retry to cost more time
*/
- @ConfField public static int thrift_client_timeout_ms = 30000;
Review comment:
in our case, query information_schema.tables. i find fe would send a TCP RST command(try tcpdump 9020 in fe) to be to close the socket becasuse of thrift_client_timeout_ms is meet, the be log comes "no more data to read", the be would retry in 1s(default).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] francisoliverlee commented on pull request #4808: [optimize] optimize default value for thriftserver's config key "thrift_client_timeout_ms"
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on pull request #4808:
URL: https://github.com/apache/incubator-doris/pull/4808#issuecomment-719139355
> @francisoliverlee Please provide an issue related to this PR.
https://github.com/apache/incubator-doris/issues/4824
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #4808: [optimize] optimize default value for thriftserver's config key "thrift_client_timeout_ms"
Posted by GitBox <gi...@apache.org>.
caiconghui commented on a change in pull request #4808:
URL: https://github.com/apache/incubator-doris/pull/4808#discussion_r514927892
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -318,8 +318,10 @@
* The connection timeout and socket timeout config for thrift server
* The value for thrift_client_timeout_ms is set to be larger than zero to prevent
* some hang up problems in java.net.SocketInputStream.socketRead0
+ *
Review comment:
```
The connection timeout and socket timeout config for thrift server
The default value for thrift_client_timeout_ms is set to be zero to prevent readtimeout
```
@ConfField public static int thrift_client_timeout_ms = 0;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org