You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/12/01 04:08:47 UTC
[GitHub] [shenyu] ywj1352 opened a new pull request, #4231: [Task]api-doc add field and detail crud(#4029)
ywj1352 opened a new pull request, #4231:
URL: https://github.com/apache/shenyu/pull/4231
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang merged pull request #4231: [Task]api-doc add field and detail crud(#4029)
Posted by GitBox <gi...@apache.org>.
dragon-zhang merged PR #4231:
URL: https://github.com/apache/shenyu/pull/4231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang commented on a diff in pull request #4231: [Task]api-doc add field and detail crud(#4029)
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #4231:
URL: https://github.com/apache/shenyu/pull/4231#discussion_r1036918707
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/query/FieldQuery.java:
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.model.query;
+
+import org.apache.shenyu.admin.model.page.PageParameter;
+
+import java.util.Objects;
+
+public class FieldQuery {
+
+ /**
+ * the fieldName.
+ */
+ private String name;
+
+ /**
+ * the field desc.
+ */
+ private String fieldDesc;
+
+
+ /**
+ * the ext.
+ */
+ private String ext;
Review Comment:
please remove `ext` condition, it is appropriate to use ES, but ES is too complex, so this condition is abandoned directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] ywj1352 commented on a diff in pull request #4231: [Task]api-doc add field and detail crud(#4029)
Posted by GitBox <gi...@apache.org>.
ywj1352 commented on code in PR #4231:
URL: https://github.com/apache/shenyu/pull/4231#discussion_r1037010971
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/query/FieldQuery.java:
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.model.query;
+
+import org.apache.shenyu.admin.model.page.PageParameter;
+
+import java.util.Objects;
+
+public class FieldQuery {
+
+ /**
+ * the fieldName.
+ */
+ private String name;
+
+ /**
+ * the field desc.
+ */
+ private String fieldDesc;
+
+
+ /**
+ * the ext.
+ */
+ private String ext;
Review Comment:
done
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/query/FieldQuery.java:
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.model.query;
+
+import org.apache.shenyu.admin.model.page.PageParameter;
+
+import java.util.Objects;
+
+public class FieldQuery {
+
+ /**
+ * the fieldName.
+ */
+ private String name;
+
+ /**
+ * the field desc.
+ */
+ private String fieldDesc;
+
+
+ /**
+ * the ext.
+ */
+ private String ext;
Review Comment:
done
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/FieldController.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.controller;
+
+import org.apache.shenyu.admin.model.dto.FieldDTO;
+import org.apache.shenyu.admin.model.page.PageParameter;
+import org.apache.shenyu.admin.model.query.FieldQuery;
+import org.apache.shenyu.admin.model.result.ShenyuAdminResult;
+import org.apache.shenyu.admin.service.FieldService;
+import org.apache.shenyu.admin.utils.ShenyuResultMessage;
+import org.springframework.validation.annotation.Validated;
+import org.springframework.web.bind.annotation.DeleteMapping;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RequestParam;
+import org.springframework.web.bind.annotation.RestController;
+
+import javax.validation.Valid;
+import javax.validation.constraints.NotBlank;
+import javax.validation.constraints.NotEmpty;
+import javax.validation.constraints.NotNull;
+import java.util.List;
+
+@Validated
+@RestController
+@RequestMapping("/field")
+public class FieldController {
+ private final FieldService fieldService;
+
+ public FieldController(final FieldService fieldService) {
+ this.fieldService = fieldService;
+ }
+
+ /**
+ * create or update mockRequestRecord.
+ *
+ * @param fieldDTO fieldDTO.
+ * @return {@linkplain ShenyuAdminResult}
+ */
+ @PostMapping("/insertOrUpdate")
+ public ShenyuAdminResult createOrUpdate(@Valid @RequestBody final FieldDTO fieldDTO) {
+ return ShenyuAdminResult.success(ShenyuResultMessage.SUCCESS, fieldService.createOrUpdate(fieldDTO));
+ }
+
+ /**
+ * batch delete.
+ *
+ * @param ids ids
+ * @return {@linkplain ShenyuAdminResult}
+ */
+ @DeleteMapping("/batchDelete")
+ public ShenyuAdminResult batchDelete(@RequestBody @NotEmpty final List<@NotBlank String> ids) {
+ Integer deleteCount = fieldService.deleteBatch(ids);
+ return ShenyuAdminResult.success(ShenyuResultMessage.DELETE_SUCCESS, deleteCount);
+ }
+
+ /**
+ * findPageByQuery.
+ *
+ * @param name name
+ * @param fieldDesc fieldDesc
+ * @param ext ext
+ * @param currentPage currentPage
+ * @param pageSize pageSize
+ * @return {@linkplain ShenyuAdminResult}
+ */
+ @GetMapping("/findPageByQuery")
+ public ShenyuAdminResult listByPage(final String name, final String fieldDesc, final String ext,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang commented on a diff in pull request #4231: [Task]api-doc add field and detail crud(#4029)
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #4231:
URL: https://github.com/apache/shenyu/pull/4231#discussion_r1036931536
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/FieldController.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.controller;
+
+import org.apache.shenyu.admin.model.dto.FieldDTO;
+import org.apache.shenyu.admin.model.page.PageParameter;
+import org.apache.shenyu.admin.model.query.FieldQuery;
+import org.apache.shenyu.admin.model.result.ShenyuAdminResult;
+import org.apache.shenyu.admin.service.FieldService;
+import org.apache.shenyu.admin.utils.ShenyuResultMessage;
+import org.springframework.validation.annotation.Validated;
+import org.springframework.web.bind.annotation.DeleteMapping;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RequestParam;
+import org.springframework.web.bind.annotation.RestController;
+
+import javax.validation.Valid;
+import javax.validation.constraints.NotBlank;
+import javax.validation.constraints.NotEmpty;
+import javax.validation.constraints.NotNull;
+import java.util.List;
+
+@Validated
+@RestController
+@RequestMapping("/field")
+public class FieldController {
+ private final FieldService fieldService;
+
+ public FieldController(final FieldService fieldService) {
+ this.fieldService = fieldService;
+ }
+
+ /**
+ * create or update mockRequestRecord.
+ *
+ * @param fieldDTO fieldDTO.
+ * @return {@linkplain ShenyuAdminResult}
+ */
+ @PostMapping("/insertOrUpdate")
+ public ShenyuAdminResult createOrUpdate(@Valid @RequestBody final FieldDTO fieldDTO) {
+ return ShenyuAdminResult.success(ShenyuResultMessage.SUCCESS, fieldService.createOrUpdate(fieldDTO));
+ }
+
+ /**
+ * batch delete.
+ *
+ * @param ids ids
+ * @return {@linkplain ShenyuAdminResult}
+ */
+ @DeleteMapping("/batchDelete")
+ public ShenyuAdminResult batchDelete(@RequestBody @NotEmpty final List<@NotBlank String> ids) {
+ Integer deleteCount = fieldService.deleteBatch(ids);
+ return ShenyuAdminResult.success(ShenyuResultMessage.DELETE_SUCCESS, deleteCount);
+ }
+
+ /**
+ * findPageByQuery.
+ *
+ * @param name name
+ * @param fieldDesc fieldDesc
+ * @param ext ext
+ * @param currentPage currentPage
+ * @param pageSize pageSize
+ * @return {@linkplain ShenyuAdminResult}
+ */
+ @GetMapping("/findPageByQuery")
+ public ShenyuAdminResult listByPage(final String name, final String fieldDesc, final String ext,
Review Comment:
please remove `ext` condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang commented on a diff in pull request #4231: [Task]api-doc add field and detail crud(#4029)
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #4231:
URL: https://github.com/apache/shenyu/pull/4231#discussion_r1036918931
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/query/FieldQuery.java:
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.model.query;
+
+import org.apache.shenyu.admin.model.page.PageParameter;
+
+import java.util.Objects;
+
+public class FieldQuery {
+
+ /**
+ * the fieldName.
+ */
+ private String name;
+
+ /**
+ * the field desc.
+ */
+ private String fieldDesc;
+
+
+ /**
+ * the ext.
+ */
+ private String ext;
Review Comment:
please remove `ext` condition, it is appropriate to use ES, but ES is too complex, so this field is abandoned directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org