You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/01 07:07:19 UTC

[GitHub] [iotdb] cigarl commented on issue #3881: [Cluster-refactor] About refine classes name

cigarl commented on issue #3881:
URL: https://github.com/apache/iotdb/issues/3881#issuecomment-909987628


   > 2. The naming of class in **RPC interface layer** should contain `ThriftServerImpl` or `RPCServerImpl`, and place them in a separate package called `xxx.thrift.impl` or `xxx.rpc.impl`. These names clearly indicate that they are implementations of thrift interface. Now they are placed in the `org.apache.iotdb.cluster.server` package.
   
   I could't agree more.
   Whether it's a service that handles client requests, or a service that communicates internally, it should like a module in server.we should not nest too deeply in the `server`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org