[GitHub] [hbase] bsglz commented on a change in pull request #2042: HBASE-24704 Make the Table Schema easier to view even there are multi…

[GitBox <gi...@apache.org>]

bsglz commented on a change in pull request #2042:
URL: https://github.com/apache/hbase/pull/2042#discussion_r463915997



##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -765,40 +767,45 @@
 %>
 </table>
 <h2>Table Schema</h2>
+
 <table class="table table-striped">
+<%
+  Collection<HColumnDescriptor> families = new HTableDescriptor(table.getDescriptor()).getFamilies();

Review comment:
       Fixed, remove the unnecessary new HTableDescriptor and use ColumnFamilyDescriptor instead of HColumnDescriptor.
   Thanks.

##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -765,40 +767,45 @@
 %>
 </table>
 <h2>Table Schema</h2>
+
 <table class="table table-striped">
+<%
+  Collection<HColumnDescriptor> families = new HTableDescriptor(table.getDescriptor()).getFamilies();
+  Set<Bytes> familyKeySet = new HashSet();

Review comment:
       Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org