You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/23 07:00:37 UTC

[GitHub] [pulsar] MarvinCai commented on a change in pull request #9659: [FlakyTest]Try to fix flaky test ReplicatorTest.testReplicatorOnPartitionedTopic.

MarvinCai commented on a change in pull request #9659:
URL: https://github.com/apache/pulsar/pull/9659#discussion_r580805247



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
##########
@@ -805,7 +805,7 @@ public void testReplicatorOnPartitionedTopic(boolean isPartitionedTopic) throws
 
         log.info("--- Starting ReplicatorTest::{} --- ", methodName);
 
-        final String namespace = "pulsar/partitionedNs-" + isPartitionedTopic;
+        final String namespace = "pulsar/partitionedNs-" + isPartitionedTopic + "-" + System.nanoTime();;

Review comment:
       fixed the duplicate ";"
   It could be namespace left from other test run, the zookeeper used for test will have a temp dir to store data with same name. It could be really hard to debug in github action VM but make namespace unique across different test run should solve the issue for us.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org