You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (Created) (JIRA)" <ji...@apache.org> on 2012/03/29 03:13:26 UTC
[jira] [Created] (HBASE-5670) Have Mutation implement the Row
interface.
Have Mutation implement the Row interface.
------------------------------------------
Key: HBASE-5670
URL: https://issues.apache.org/jira/browse/HBASE-5670
Project: HBase
Issue Type: Improvement
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Trivial
In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240998#comment-13240998 ]
Lars Hofhansl commented on HBASE-5670:
--------------------------------------
Thanks Stack.
Since you can pass List<Row> to a method that takes List<? extends Row> it'll work without the need to recompile anything.
The client<->server communication is done via HConnection.processBatch, which is public and actually already takes List<? extends Row>. Seems the List<Row> interface in HTable was just an oversight.
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241017#comment-13241017 ]
Hadoop QA commented on HBASE-5670:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520372/5670-trunk.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1337//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1337//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1337//console
This message is automatically generated.
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242472#comment-13242472 ]
Hudson commented on HBASE-5670:
-------------------------------
Integrated in HBase-TRUNK #2698 (See [https://builds.apache.org/job/HBase-TRUNK/2698/])
HBASE-5670 Have Mutation implement the Row interface. (Revision 1306959)
Result = FAILURE
larsh :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Append.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Put.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241419#comment-13241419 ]
Hudson commented on HBASE-5670:
-------------------------------
Integrated in HBase-0.94 #64 (See [https://builds.apache.org/job/HBase-0.94/64/])
HBASE-5670 Have Mutation implement the Row interface. (Revision 1306958)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Append.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Put.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5670:
---------------------------------
Attachment: 5670-trunk.txt
Attaching again to see if I can get a clean run.
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242061#comment-13242061 ]
Hudson commented on HBASE-5670:
-------------------------------
Integrated in HBase-TRUNK-security #154 (See [https://builds.apache.org/job/HBase-TRUNK-security/154/])
HBASE-5670 Have Mutation implement the Row interface. (Revision 1306959)
Result = FAILURE
larsh :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Append.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Put.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5670:
---------------------------------
Status: Patch Available (was: Open)
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5670:
---------------------------------
Attachment: 5670-0.94.txt
Simple patch that does just that. Mutation implements Row, and HTable.batch takes List<? extends Row>
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5670:
---------------------------------
Attachment: 5670-trunk.txt
Same for trunk
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240973#comment-13240973 ]
stack commented on HBASE-5670:
------------------------------
+1 on patch. It should be fine. I was wondering if there'd be weird down-deep incompatibility issues if a Type that had old layout was passed into an HTable#batch that expected new format but I think it'll be fine and this is all client-side stuff too... not about the hbase client to server Interface.
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242446#comment-13242446 ]
Hudson commented on HBASE-5670:
-------------------------------
Integrated in HBase-0.94-security #6 (See [https://builds.apache.org/job/HBase-0.94-security/6/])
HBASE-5670 Have Mutation implement the Row interface. (Revision 1306958)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Append.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Put.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5670:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5670:
---------------------------------
Fix Version/s: 0.94.1
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.94.1
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5670:
---------------------------------
Fix Version/s: (was: 0.94.1)
0.94.0
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.94.0, 0.96.0
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5670) Have Mutation implement the Row
interface.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240924#comment-13240924 ]
Hadoop QA commented on HBASE-5670:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520349/5670-trunk.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1335//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1335//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1335//console
This message is automatically generated.
> Have Mutation implement the Row interface.
> ------------------------------------------
>
> Key: HBASE-5670
> URL: https://issues.apache.org/jira/browse/HBASE-5670
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Trivial
> Fix For: 0.94.1
>
> Attachments: 5670-0.94.txt, 5670-trunk.txt
>
>
> In HBASE-4347 I factored some code from Put/Delete/Append in Mutation.
> In a discussion with a co-worker I noticed that Put/Delete/Append still implement the Row interface, but Mutation does not.
> In a trivial change I would like to move that interface up to Mutation, along with changing HTable.batch(List<Row>) to HTable.batch(List<? extends Row>) (HConnection.processBatch takes List<? extends Row> already anyway), so that HTable.batch can be used with a list of Mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira