[GitHub] [airflow] Lee-W commented on a diff in pull request #32643: Fix CloudTasksTaskCreateOperator system test

["Lee-W (via GitHub)" <gi...@apache.org>]

Lee-W commented on code in PR #32643:
URL: https://github.com/apache/airflow/pull/32643#discussion_r1273247134


##########
tests/system/providers/google/cloud/tasks/example_tasks.py:
##########
@@ -48,22 +45,20 @@
 ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
 DAG_ID = "cloud_tasks_tasks"
 
-timestamp = timestamp_pb2.Timestamp()
-timestamp.FromDatetime(datetime.now() + timedelta(hours=12))
+TIMESTAMP = timestamp_pb2.Timestamp()
+TIMESTAMP.FromDatetime(datetime.now() + timedelta(hours=12))
 
-LOCATION = os.environ.get("GCP_APP_ENGINE_LOCATION", "europe-west2")
+REGION = "us-central1"

Review Comment:
   May I know why we want to change the variable name from `LOCATION` to `REGION`? Both seem to work. Also, should we keep the env var for easier customization?



##########
tests/system/providers/google/cloud/tasks/example_tasks.py:
##########
@@ -48,22 +45,20 @@
 ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
 DAG_ID = "cloud_tasks_tasks"
 
-timestamp = timestamp_pb2.Timestamp()
-timestamp.FromDatetime(datetime.now() + timedelta(hours=12))
+TIMESTAMP = timestamp_pb2.Timestamp()

Review Comment:
   May I know why do we want to make it upper case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org