You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "yevgenypats (via GitHub)" <gi...@apache.org> on 2023/04/07 14:30:12 UTC

[GitHub] [arrow] yevgenypats commented on a diff in pull request #34854: GH-34853: [Go] Add TotalRecordSize, TotalArraySize

yevgenypats commented on code in PR #34854:
URL: https://github.com/apache/arrow/pull/34854#discussion_r1160741537


##########
go/arrow/array/record.go:
##########
@@ -180,6 +179,14 @@ func (rec *simpleRecord) SetColumn(i int, arr arrow.Array) (arrow.Record, error)
 	return NewRecord(rec.schema, arrs, rec.rows), nil
 }
 
+func (rec *simpleRecord) TotalBufferSize() uint64 {

Review Comment:
   I removed this method as we can't add it to the interface given it will cause the cyclical loop



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org