[jira] [Comment Edited] (PDFBOX-4538) Expose more internal API as protected and public

["Tilman Hausherr (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836295#comment-16836295 ] 

Tilman Hausherr edited comment on PDFBOX-4538 at 5/9/19 11:35 AM:
------------------------------------------------------------------

There is a text somewhere that explains why we don't expose much, I can't find it, but "Effective Java" has a similar explanation. Exposing everything means that internals can't be changed easily without changing the version, and also people come up with weird manipulations that were not thought about in the first place.

The better thing to do would be to ask what change you need, and maybe we can add it.


was (Author: tilman):
There is a text somewhere that explains why we don't expose much, I can't find it, but "Effective Java" has a similar explanation. Exposing everything means that internals can't be changed easily without changing the version, and also people come up with weird manipulations that were not thought about in the first place.

> Expose more internal API as protected and public
> ------------------------------------------------
>
>                 Key: PDFBOX-4538
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4538
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Parsing, Rendering, Writing
>    Affects Versions: 2.0.14
>            Reporter: Jonathan
>            Priority: Minor
>              Labels: pull-request-available
>
> During the last couple of weeks, I worked intensely on PDFBox-based, heavy PDF processing.
>  In the course of this work, we often needed to customize some behaviour of the library, but we haven't been able to do this as an extension by subclassing. Instead, we needed to fork the entire project, with the majority of changes being the use of less restrictive access modifiers.
> As a company we would like to reduce the scope of our own modifications, so it'd be great if you could adopt a somewhat less restrictive policy on exposing API area. I could compile a list of the symbols we needed, but perhaps it would make sense to undergo a more general review about what internals could be opened as public API.
> We also implemented some other fixes, I will open separate issues to address them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org