[GitHub] [superset] AAfghahi commented on a diff in pull request #20755: feat: blankstate metrics columns

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #20755:
URL: https://github.com/apache/superset/pull/20755#discussion_r924934420


##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx:
##########
@@ -261,7 +275,7 @@ const ColumnSelectPopover = ({
                 }))}
               />
             </FormItem>
-          ) : (
+          ) : datasourceType === 'dataset' ? (

Review Comment:
   I think it might be better to check this with the DatasourceType enum



##########
superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.jsx:
##########
@@ -370,14 +370,34 @@ export default class AdhocMetricEditPopover extends React.PureComponent {
                   {...savedSelectProps}
                 />
               </FormItem>
-            ) : (
+            ) : datasource.type === 'dataset' ? (

Review Comment:
   same here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org