You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Murat Yücel (JIRA)" <ji...@apache.org> on 2008/06/30 21:02:45 UTC

[jira] Created: (WICKET-1721) FormTester doesnt support onSelectionChanged for RadioChoice

FormTester doesnt support onSelectionChanged  for RadioChoice
-------------------------------------------------------------

                 Key: WICKET-1721
                 URL: https://issues.apache.org/jira/browse/WICKET-1721
             Project: Wicket
          Issue Type: Bug
          Components: wicket
         Environment: Doesn't matter
            Reporter: Murat Yücel


It is not possible to test onSelectionChanged for RadioChoice and probably also other form components.

See this thread:
http://www.nabble.com/Problem-test-RadioChoice-td18196023.html#a18196023

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1721) FormTester doesnt support onSelectionChanged for RadioChoice

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-1721:
----------------------------------

    Fix Version/s: 1.5-M3
                       (was: 1.5-M2)

> FormTester doesnt support onSelectionChanged  for RadioChoice
> -------------------------------------------------------------
>
>                 Key: WICKET-1721
>                 URL: https://issues.apache.org/jira/browse/WICKET-1721
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: Doesn't matter
>            Reporter: Murat Yücel
>             Fix For: 1.5-M3
>
>
> It is not possible to test onSelectionChanged for RadioChoice and probably also other form components.
> See this thread:
> http://www.nabble.com/Problem-test-RadioChoice-td18196023.html#a18196023

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1721) FormTester doesnt support onSelectionChanged for RadioChoice

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-1721:
-------------------------------------

    Fix Version/s:     (was: 1.5-M3)
                   1.5-M4

> FormTester doesnt support onSelectionChanged  for RadioChoice
> -------------------------------------------------------------
>
>                 Key: WICKET-1721
>                 URL: https://issues.apache.org/jira/browse/WICKET-1721
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: Doesn't matter
>            Reporter: Murat Yücel
>             Fix For: 1.5-M4
>
>
> It is not possible to test onSelectionChanged for RadioChoice and probably also other form components.
> See this thread:
> http://www.nabble.com/Problem-test-RadioChoice-td18196023.html#a18196023

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1721) FormTester doesnt support onSelectionChanged for RadioChoice

Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610120#action_12610120 ] 

Timo Rantalaiho commented on WICKET-1721:
-----------------------------------------

I think that I have sometimes worked around this issues by calling onSelectionChanged() manually in the tests, e.g. something like

{code:java}
formTester.getForm().visitChildren(RadioChoice.class, new IVisitor<RadioChoice>() {
    public Object component(RadioChoice component) {
        component.onSelectionChanged();
        return CONTINUE_TRAVERSAL;
    }
});
{code}

If the workaround works, I'd be hesitant to fix this in 1.3 / 1.4 because it would change the existing behavior and might break existing tests. But this should definitely be addressed in 1.5, so we could set the fix version there. What do you think?

> FormTester doesnt support onSelectionChanged  for RadioChoice
> -------------------------------------------------------------
>
>                 Key: WICKET-1721
>                 URL: https://issues.apache.org/jira/browse/WICKET-1721
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: Doesn't matter
>            Reporter: Murat Yücel
>
> It is not possible to test onSelectionChanged for RadioChoice and probably also other form components.
> See this thread:
> http://www.nabble.com/Problem-test-RadioChoice-td18196023.html#a18196023

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1721) FormTester doesnt support onSelectionChanged for RadioChoice

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-1721:
----------------------------------

    Fix Version/s: 1.5-M2
                       (was: 1.5-M1)

> FormTester doesnt support onSelectionChanged  for RadioChoice
> -------------------------------------------------------------
>
>                 Key: WICKET-1721
>                 URL: https://issues.apache.org/jira/browse/WICKET-1721
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: Doesn't matter
>            Reporter: Murat Yücel
>             Fix For: 1.5-M2
>
>
> It is not possible to test onSelectionChanged for RadioChoice and probably also other form components.
> See this thread:
> http://www.nabble.com/Problem-test-RadioChoice-td18196023.html#a18196023

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1721) FormTester doesnt support onSelectionChanged for RadioChoice

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-1721:
----------------------------------

    Fix Version/s: 1.5-M1

sounds reasonable to fix in 1.5 so that we do not break existing 1.3/1.4 behavior. +1 for that.

> FormTester doesnt support onSelectionChanged  for RadioChoice
> -------------------------------------------------------------
>
>                 Key: WICKET-1721
>                 URL: https://issues.apache.org/jira/browse/WICKET-1721
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: Doesn't matter
>            Reporter: Murat Yücel
>             Fix For: 1.5-M1
>
>
> It is not possible to test onSelectionChanged for RadioChoice and probably also other form components.
> See this thread:
> http://www.nabble.com/Problem-test-RadioChoice-td18196023.html#a18196023

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.