You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/11/10 15:51:54 UTC
[GitHub] [incubator-streampark] green241 opened a new pull request, #2001: Add i18n support for flink app menu(ps:Recent continuous improvement).
green241 opened a new pull request, #2001:
URL: https://github.com/apache/incubator-streampark/pull/2001
Add i18n support for flink app menu(ps:Recent continuous improvement).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wangsizhu0504 commented on pull request #2001: Add i18n support for flink app menu(ps:Recent continuous improvement).
Posted by GitBox <gi...@apache.org>.
wangsizhu0504 commented on PR #2001:
URL: https://github.com/apache/incubator-streampark/pull/2001#issuecomment-1311001558
In fact, I have never encountered such incidents. However, the correct thing is that you need to pull the latest code on the branch you modify, manually resolve the conflict, and then submit the post-conflict code.
But I seem to find that you didn't indicate a conflict. Let me check your submission first. If there is no problem, I will merge it. Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] green241 commented on pull request #2001: Add i18n support for flink app menu(ps:Recent continuous improvement).
Posted by GitBox <gi...@apache.org>.
green241 commented on PR #2001:
URL: https://github.com/apache/incubator-streampark/pull/2001#issuecomment-1310592693
Well, if there is a conflict in the code, this pr need to be closed.
This is indeed a problem. In fact, when changing this part of the code, it is usually done at night, and the latest corresponding branch code is pulled before submitting. If there is a conflict, it will be resolved before submitting.
However, there is a problem. For example, a developer submits the code first but does not merge it. At this time, when another developer submits the code, it cannot pull the code to be merged by the previous developer.
Anyway, I'm still very happy that streampark is gradually improving, come on!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wangsizhu0504 merged pull request #2001: Add i18n support for flink app menu
Posted by GitBox <gi...@apache.org>.
wangsizhu0504 merged PR #2001:
URL: https://github.com/apache/incubator-streampark/pull/2001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wangsizhu0504 commented on pull request #2001: Add i18n support for flink app menu(ps:Recent continuous improvement).
Posted by GitBox <gi...@apache.org>.
wangsizhu0504 commented on PR #2001:
URL: https://github.com/apache/incubator-streampark/pull/2001#issuecomment-1310528143
Thank you for your contribution. It is recommended that you create a new branch with the latest code and modify it on the new branch before submitting it to avoid code conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] green241 commented on pull request #2001: Add i18n support for flink app menu
Posted by GitBox <gi...@apache.org>.
green241 commented on PR #2001:
URL: https://github.com/apache/incubator-streampark/pull/2001#issuecomment-1311100398
> In fact, I have never encountered such incidents. However, the correct thing is that you need to pull the latest code on the branch you modify, manually resolve the conflict, and then submit the post-conflict code.
>
> But I seem to find that you didn't indicate a conflict. Let me check your submission first. If there is no problem, I will merge it. Thank you very much!
oka, i will check my local branch. Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org