You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/13 07:09:20 UTC
[GitHub] [maven-fluido-skin] kwin opened a new pull request, #37: [MSKINS-194] load GitHub ribbon with CSS
kwin opened a new pull request, #37:
URL: https://github.com/apache/maven-fluido-skin/pull/37
prevent loading images from AWS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] asfgit closed pull request #37: [MSKINS-194] load GitHub ribbon with CSS
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #37: [MSKINS-194] load GitHub ribbon with CSS
URL: https://github.com/apache/maven-fluido-skin/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on a diff in pull request #37: [MSKINS-194] load GitHub ribbon with CSS
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #37:
URL: https://github.com/apache/maven-fluido-skin/pull/37#discussion_r895392726
##########
src/main/resources/css/gh-fork-ribbon.css:
##########
@@ -0,0 +1,124 @@
+/*!
+ * "Fork me on GitHub" CSS ribbon v0.2.3 | MIT License
+ * https://github.com/simonwhitaker/github-fork-ribbon-css
Review Comment:
Do we need to reflect this 3rd party license somehow, e.g. in LICENSE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #37: [MSKINS-194] load GitHub ribbon with CSS
Posted by GitBox <gi...@apache.org>.
stevecrox commented on PR #37:
URL: https://github.com/apache/maven-fluido-skin/pull/37#issuecomment-1155718107
mskins-22 and mskins-22_default have examples which display the github overlay, both render correctly and are embedded into the bar. Seems a good change to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org